Review TYPO3_7-6 Merged

47423[BUGFIX] Fail with exit code for fatal errors during boot

Helmut Hummel CR +2 V +2 Normal +41 −10 updated 03/30/16, 19:45

Commit message

Especially for CI environments it is crucial that TYPO3
does not exit cleanly when a fatal error occurs.

Change from die (which exits with return code 0) to exit(1)
and send a http error code as well (in web requests)

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Christian Kuhn +1
    • Morton Jonuschat +1
  • Verified V +2
    • Helmut Hummel +2
    • Christian Kuhn +1
    • Tymoteusz Motylewski +1
    • Morton Jonuschat +1

Issues 1

Files 3

Review log 8

  1. Helmut Hummel uploaded patch set 1 03/30/16, 13:09

  2. Christian Kuhn commented on patch set 1 CR -1 03/30/16, 17:28

    master patch will probably receive a follow-up that should be integrated here directly. will take care.
  3. Christian Kuhn uploaded patch set 2 03/30/16, 19:32

  4. Christian Kuhn voted on patch set 2 CR +1 V +1 03/30/16, 19:33

  5. Morton Jonuschat voted on patch set 2 CR +1 V +1 03/30/16, 19:35

  6. Tymoteusz Motylewski commented on patch set 2 V +1 03/30/16, 19:45

    unit tests are working on 7.6
  7. Helmut Hummel commented on patch set 2 CR +2 V +2 03/30/16, 19:45

    Thanks folks for the detailed review!
  8. Gerrit merged patch set 2 03/30/16, 19:45