Review main Merged

47426[BUGFIX] Allow passing null for $methods in getAccessibleMock

Oliver Klee CR +2 V +2 Easy +2 −2 updated 03/30/16, 17:03

Commit message

The method getMock() in the parent class also allows null for
$methods, meaning "mock no methods".

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Susi Moog +1
  • Verified V +2
    • Christian Kuhn +2
    • Susi Moog +1

Issues 1

Files 1

Review log 10

  1. Oliver Klee uploaded patch set 1 03/30/16, 13:54

  2. Oliver Klee updated the commit message in patch set 2 03/30/16, 13:55

  3. Christian Kuhn updated the commit message in patch set 3 03/30/16, 13:58

  4. Christian Kuhn commented on patch set 3 CR +1 V +1 03/30/16, 14:04

    fine with me on master + 7.6, just removed 6.2 since this patch is not critical enough.
  5. Oliver Klee commented on patch set 3 03/30/16, 14:17

    Okay, thanks!
  6. Wouter Wolters voted on patch set 3 CR +1 03/30/16, 14:20

  7. Susi Moog voted on patch set 3 CR +1 V +1 03/30/16, 14:25

  8. Christian Kuhn voted on patch set 3 CR +2 V +2 03/30/16, 17:03

  9. Gerrit merged patch set 3 03/30/16, 17:03

  10. Christian Kuhn commented on patch set 4 03/30/16, 17:03

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit d349d59a531fc7a12cd6cab20f78a0a2398d9a3d