47448[FEATURE] Render Error Pages via Fluid
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Susi Moog +1
-
Verified V +2
- Anja Leichsenring +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 8
- typo3/sysext/core/Classes/Controller/ErrorPageController.php1new+94 −0
- typo3/sysext/core/Classes/Error/ProductionExceptionHandler.php+9 −13
- typo3/sysext/core/Classes/Messaging/AbstractStandaloneMessage.php+3 −0
- typo3/sysext/core/Classes/Messaging/ErrorpageMessage.php+4 −0
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-77164-ErrorpageMessageAndAbstractStandaloneMessage.rstnew+26 −0
- typo3/sysext/core/Resources/Private/Templates/ErrorPage/Error.htmlnew+48 −0
- typo3/sysext/core/Tests/Unit/Mail/MailerTest.php+5 −5
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+9 −10
Review log 1927
Show 2 earlier messages
-
Christian Kuhn commented on patch set 2 04/20/16, 09:27
ErrorPageController.php:23ok, this class has incredible little number of dependencies. that's good. using typo3fluid here directly means we do not even depend on ext:fluid. -
Benni Mack uploaded patch set 3 06/30/16, 20:35
-
TYPO3com voted on patch set 3 V -1 06/30/16, 20:38 Completed build in 02m 42s on Thu, 30 Jun, 10:38 PM Test Summary: 1 of 9645 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-362
-
Benni Mack uploaded patch set 4 07/20/16, 11:06
-
TYPO3com voted on patch set 4 V -1 07/20/16, 11:10 Completed build in 04m 33s on Wed, 20 Jul, 01:10 PM Test Summary: 2 of 19320 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1183
-
Benni Mack uploaded patch set 5 07/20/16, 11:20
-
TYPO3com voted on patch set 5 V +1 07/20/16, 11:26 Completed build in 05m 34s on Wed, 20 Jul, 01:26 PM Test Summary: 19320 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1185
-
Benni Mack uploaded patch set 6 07/20/16, 11:54
-
TYPO3com voted on patch set 6 V +1 07/20/16, 11:58 Completed build in 04m 13s on Wed, 20 Jul, 01:58 PM Test Summary: 19320 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1186
-
Benni Mack uploaded patch set 7 07/20/16, 12:02
-
TYPO3com voted on patch set 7 V +1 07/20/16, 12:08 Completed build in 05m 06s on Wed, 20 Jul, 02:08 PM Test Summary: 19320 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1188
-
Benni Mack uploaded patch set 8 07/27/16, 07:23
-
TYPO3com voted on patch set 8 V -1 07/27/16, 07:27 Completed build in 03m 39s on Wed, 27 Jul, 09:27 AM Test Summary: 19265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1393
-
Benni Mack uploaded patch set 9 07/28/16, 06:12
-
TYPO3com voted on patch set 9 V +1 07/28/16, 06:18 Completed build in 05m 21s on Thu, 28 Jul, 08:18 AM Test Summary: 19378 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1415
-
Susi Moog commented on patch set 9 CR -1 V -1 07/28/16, 19:51
the MailerTest change looks unrelated. By testing: I don't have any CSS on the error page after this change. I get a not found error on typo3/sysext/core/Resources/Public/Css/errorpage-message.css Last question: is there a possibility to overwrite the template path? -
Benni Mack uploaded patch set 10 07/31/16, 11:46
-
Benni Mack commented on patch set 10 07/31/16, 11:47
The MailerTest change is needed because there was a check against a class which is now marked as deprecated, which I switched for that reason. -
Susi Moog commented on patch set 10 08/01/16, 11:08
ah, sorry, didn't see the class name change, only the spelling correction - will test again this evening. -
Benni Mack commented on patch set 10 CR -1 08/02/16, 06:06
Should use strict typing for new class, will update during the day -
Benni Mack uploaded patch set 11 08/02/16, 10:48
-
TYPO3com voted on patch set 11 V +1 08/02/16, 10:58 Completed build in 06m 07s on Tue, 2 Aug, 12:58 PM Test Summary: 19380 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1573
-
Susi Moog voted on patch set 11 CR +1 V +1 08/02/16, 18:18
-
Anja Leichsenring voted on patch set 11 CR +2 V +2 08/03/16, 12:58
-
Gerrit merged patch set 11 08/03/16, 12:58