Review main Merged

47449[TASK] Deprecate $TSFE->csConvObj

Benni Mack CR +2 V +2 Normal +60 −16 updated 04/01/16, 09:29

Commit message

The CharsetConverter class is now a singleton and not
depending on a context (FE/BE) as it always takes the
needed charset for conversion as parameter.

$LANG->csConv is already deprecated, this patch
cleans up the last bits inside TypoScriptFrontendController
and therefore deprecates $TSFE->csConvObj
and $TSFE->csConv().

Review

  • Code review CR +2
    • Morton Jonuschat +2
    • Markus Sommer +1
  • Verified V +2
    • Morton Jonuschat +2
    • Markus Sommer +1

Issues 1

Files 7

Review log 9

  1. Benni Mack uploaded patch set 1 03/31/16, 07:18

  2. Benni Mack uploaded patch set 2 04/01/16, 08:46

  3. Markus Sommer voted on patch set 2 CR +1 V +1 04/01/16, 09:07

  4. Morton Jonuschat commented on patch set 2 04/01/16, 09:14

    Do we need to mark this as breaking as the public property is being removed?
  5. Benni Mack commented on patch set 2 04/01/16, 09:25

    which property gets removed?
  6. Benni Mack commented on patch set 2 04/01/16, 09:26

    its still there and initialized on every FE request, but just not accessed any more by the core.
  7. Morton Jonuschat commented on patch set 2 CR +1 V +1 04/01/16, 09:26

    Right.
  8. Morton Jonuschat voted on patch set 2 CR +2 V +2 04/01/16, 09:29

  9. Gerrit merged patch set 2 04/01/16, 09:29