47449[TASK] Deprecate $TSFE->csConvObj
Commit message
Review
-
Code review CR +2
- Morton Jonuschat +2
- Markus Sommer +1
-
Verified V +2
- Morton Jonuschat +2
- Markus Sommer +1
Issues 1
Files 7
- typo3/sysext/compatibility7/Classes/Controller/SearchFormController.php+1 −1
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-75327-TSFE-csConvObjAndTSFE-csConv.rstnew+34 −0
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+10 −8
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+15 −4
- typo3/sysext/frontend/Tests/Unit/ContentObject/CaseContentObjectTest.php+0 −1
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+0 −1
- typo3/sysext/frontend/Tests/Unit/ContentObject/FilesContentObjectTest.php+0 −1
Review log 9
-
Benni Mack uploaded patch set 1 03/31/16, 07:18
-
Benni Mack uploaded patch set 2 04/01/16, 08:46
-
Markus Sommer voted on patch set 2 CR +1 V +1 04/01/16, 09:07
-
Morton Jonuschat commented on patch set 2 04/01/16, 09:14
Do we need to mark this as breaking as the public property is being removed? -
Benni Mack commented on patch set 2 04/01/16, 09:25
which property gets removed? -
Benni Mack commented on patch set 2 04/01/16, 09:26
its still there and initialized on every FE request, but just not accessed any more by the core. -
Morton Jonuschat commented on patch set 2 CR +1 V +1 04/01/16, 09:26
Right. -
Morton Jonuschat voted on patch set 2 CR +2 V +2 04/01/16, 09:29
-
Gerrit merged patch set 2 04/01/16, 09:29