Review main Merged

47455[BUGFIX] config.locale_all should format floating point values

Xavier Perseguers CR +2 V +2 Easy +2 −9 updated 04/20/16, 20:59

Commit message

The bug with LC_NUMERIC existed in PHP 4.2.3 but is fixed since at least
PHP 5.1.6. The patch uses LC_ALL now.

Review

  • Code review CR +2
    • Benni Mack +2
    • Christian Kuhn +1
    • Xavier Perseguers +1
  • Verified V +2
    • Benni Mack +2
    • Christian Kuhn +1

Issues 1

Files 1

Review log 10

  1. Xavier Perseguers uploaded patch set 1 03/31/16, 09:22

  2. Benni Mack commented on patch set 1 03/31/16, 09:55

    TypoScriptFrontendController.php:2739

    could we then just use LC_ALL now as the comment stated?
  3. Xavier Perseguers commented on patch set 1 03/31/16, 10:43

    TypoScriptFrontendController.php:2739 Reply

    Sure, we are actually still missing LC_MESSAGES here, and it would certainly make sense to possibly get localized system messages as well.
  4. Benni Mack uploaded patch set 2 03/31/16, 10:52

  5. Benni Mack voted on patch set 2 CR +1 03/31/16, 10:53

  6. Xavier Perseguers voted on patch set 2 CR +1 03/31/16, 10:53

  7. Christian Kuhn voted on patch set 2 CR +1 V +1 03/31/16, 11:04

  8. Benni Mack voted on patch set 2 CR +2 V +2 03/31/16, 11:18

  9. Gerrit merged patch set 2 03/31/16, 11:18

  10. Nicole Hummel commented on patch set 3 04/20/16, 20:59

    Reverted This patchset was reverted in change: I83a443617e50a86b0297c49887e94f226104c910