Review main Merged

47475[TASK] Add available commands to console output

Wouter Wolters CR +2 V +2 Easy +15 −2 updated 12/08/16, 20:25

Commit message

When no valid key or command is given only the cliKeys are written
on the CLI. Now the available commands are written as well.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Susi Moog +1
  • Verified V +2
    • Christian Kuhn +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1116

  1. Wouter Wolters uploaded patch set 1 03/31/16, 20:51

  2. Wouter Wolters updated the commit message in patch set 2 03/31/16, 20:53

  3. Susi Moog commented on patch set 2 CR -1 04/01/16, 06:54

    after the patch we have the exact same code/methods in two places in the core (CliRequestHandler and CommandRequestHandler). Could we move that method somewhere where it simply may be used by both?
  4. Wouter Wolters commented on patch set 2 04/01/16, 07:00

    the code is not exactly the same ;)
  5. TYPO3com voted on patch set 2 V +1 12/04/16, 11:38 Completed build in 38m 08s on Sun, 4 Dec, 12:38 PM Test Summary: 54322 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5483

  6. Wouter Wolters uploaded patch set 3 12/07/16, 14:04

  7. Wouter Wolters uploaded patch set 4 12/07/16, 14:09

  8. TYPO3com voted on patch set 3 V +1 12/07/16, 14:09 Completed build in 05m 14s on Wed, 7 Dec, 03:09 PM Test Summary: 54373 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5573

  9. Wouter Wolters uploaded patch set 5 12/07/16, 14:09

  10. Wouter Wolters uploaded patch set 6 12/07/16, 14:10

  11. TYPO3com voted on patch set 4 V -1 12/07/16, 14:14 Completed build in 05m 21s on Wed, 7 Dec, 03:14 PM Test Summary: 54373 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5574

  12. Susi Moog voted on patch set 6 CR +1 V +1 12/07/16, 14:15

  13. TYPO3com voted on patch set 5 V -1 12/07/16, 14:16 Completed build in 06m 24s on Wed, 7 Dec, 03:16 PM Test Summary: 54373 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5575

  14. TYPO3com voted on patch set 6 V +1 12/07/16, 14:17 Completed build in 06m 49s on Wed, 7 Dec, 03:17 PM Test Summary: 54373 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5576

  15. Christian Kuhn voted on patch set 6 CR +2 V +2 12/08/16, 20:25

  16. Gerrit merged patch set 6 12/08/16, 20:25