Review main Abandoned

47477[BUGFIX] Only update reference index on workspace swapping

Stefan Rotsch CR 0 V 0 Normal +54 −6 updated 09/23/20, 13:59

Commit message

Fixes a regression of errors like "Element "sys_file_reference:XXX" does not exist"
introduced with #64253 causing the Workspace module to fail loading the list
of changes under certain circumstances.

This change only updates the reference index, when a record is swapped
and not when a regular publishing process is given, whereas the reference
index should not do this with the swapped record when a simple publishing
happened, which led to the defined error.

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 2

Review log 2843

Show 1218 earlier messages
  1. Stefan Rotsch uploaded patch set 1 04/01/16, 07:39

  2. Oliver Hader commented on patch set 1 04/01/16, 12:30

    Thx. I'm going to have a look into the tests
  3. Oliver Hader commented on patch set 1 CR -1 04/01/16, 13:58

    I'm going to restructure the test cases. I'm not sure yet in general about the change that has been introduced in issue #64253...
  4. Stefan Rotsch commented on patch set 1 04/01/16, 14:20

    Thx for your quick response. I also feel pretty insecure about #64253 but am 99% sure it introduced this issue. Is there anything I can do?
  5. Daniel Goerz commented on patch set 1 04/01/16, 19:05

    Please rather phrase what is changed here.
  6. TYPO3com voted on patch set 1 V -1 12/04/16, 11:29 Completed build in 31m 52s on Sun, 4 Dec, 12:29 PM Test Summary: 2 of 54324 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5479

  7. Oliver Hader updated the commit message in patch set 2 10/02/17, 06:28

  8. TYPO3com voted on patch set 2 V -1 10/02/17, 06:29 Completed build in 08s on Mon, 2 Oct, 08:29 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15246

  9. Oliver Hader uploaded patch set 3 10/02/17, 06:33

  10. TYPO3com voted on patch set 3 V -1 10/02/17, 06:46 Completed build in 12m 53s on Mon, 2 Oct, 08:46 AM Test Summary: 3 of 57125 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15247

  11. Mathias Schreiber uploaded patch set 4 02/06/18, 09:17

  12. TYPO3com voted on patch set 4 V -1 02/06/18, 09:22 Completed build in 05m 29s on Tue, 6 Feb, 10:22 AM Test Summary: 2 of 30573 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19001

  13. TYPO3com commented on patch set 4 02/06/18, 13:13 Completed build in 4h 02m 15s on Tue, 6 Feb, 02:13 PM Test Summary: 2 of 30573 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19001

  14. Mathias Brodala commented on patch set 4 03/09/18, 14:00

    Stefan, can you have another look at this?
  15. Benni Mack wrote 10/26/18, 12:38

    Topic set to workspaces
  16. Benni Mack uploaded patch set 5 10/26/18, 12:45

  17. TYPO3com voted on patch set 5 V +1 10/26/18, 12:58 Completed build in 13m 03s on Fri, 26 Oct, 02:58 PM Test Summary: 37822 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29596

  18. Benni Mack updated the commit message in patch set 6 12/14/18, 10:00

  1. TYPO3com voted on patch set 6 V +1 12/14/18, 11:02 Completed build in 1h 00m 11s on Fri, 14 Dec, 12:02 PM Test Summary: 48760 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30696

  2. Benni Mack rebased onto patch set 7 09/26/19, 11:26

  3. Benni Mack uploaded patch set 8 09/26/19, 11:27

  4. Benni Mack voted on patch set 8 CR +1 09/26/19, 11:28

  5. TYPO3com voted on patch set 7 V +1 09/26/19, 11:41 Completed build in 14m 37s on Thu, 26 Sep, 11:41 AM Test Summary: 47731 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36854

  6. Benni Mack updated the commit message in patch set 9 09/26/19, 11:42

  7. Daniel Goerz voted on patch set 9 CR +1 09/26/19, 11:44

  8. TYPO3com voted on patch set 8 V +1 09/26/19, 11:47 Completed build in 16m 14s on Thu, 26 Sep, 11:47 AM Test Summary: 47731 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36856

  9. TYPO3com voted on patch set 9 V -1 09/26/19, 11:52 Completed build in 09m 58s on Thu, 26 Sep, 11:52 AM Test Summary: 1 of 48090 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36857

  10. TYPO3com voted on patch set 9 V +1 09/26/19, 11:53 Completed build in 21m 34s on Thu, 26 Sep, 11:53 AM Test Summary: 47731 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36857

  11. Benni Mack voted on patch set 9 CR +1 09/27/19, 09:22

  12. Oliver Hader commented on patch set 9 09/27/19, 12:07

    ActionTest.php:273 Unresolved

    personally, I'd prefer to have it for Modify and PublishAll scenarios as well

    ActionTest.php:285 Unresolved

    is this asserting something?

    ActionTest.php:294 Unresolved

    should be part of test method instead
  13. Benni Mack uploaded patch set 10 09/27/19, 15:22

  14. Benni Mack commented on patch set 10 CR -1 09/27/19, 15:22

    will continue to work on this one.
  15. TYPO3com voted on patch set 10 V -1 09/27/19, 15:34 Completed build in 11m 47s on Fri, 27 Sep, 03:34 PM Test Summary: 9 of 48084 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36906

  16. Benni Mack uploaded patch set 11 04/30/20, 07:15

  17. Benni Mack updated the commit message in patch set 12 04/30/20, 07:15

  18. TYPO3com voted on patch set 11 V -1 04/30/20, 07:38 Completed build in 15m 56s on Thu, 30 Apr, 07:38 AM Test Summary: 9 of 74156 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3116

  19. TYPO3com voted on patch set 12 V -1 04/30/20, 07:42 Completed build in 20m 20s on Thu, 30 Apr, 07:42 AM Test Summary: 9 of 74156 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3117

  20. Benni Mack updated the commit message in patch set 13 05/25/20, 18:48

  21. Benni Mack rebased onto patch set 14 08/04/20, 12:07

  22. TYPO3com voted on patch set 14 V -1 08/04/20, 12:19 Completed build in 11m 02s on Tue, 4 Aug, 12:19 PM Test Summary: 9 of 73450 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4397

  23. Christian Kuhn commented on patch set 14 09/22/20, 22:44

    Trying to fix this issue with a new approach in https://review.typo3.org/c/Packages/TYPO3.CMS/+/65809 now
  24. Christian Kuhn commented on patch set 14 09/23/20, 13:59

    Hey Stefan! Thanks for your patch and the long waiting time ... We finally have a solid base coverage of the reference index state, so we can now create a patch that fixes this issue. I came up with patch https://review.typo3.org/c/Packages/TYPO3.CMS/+/65809 . Your works on the test case was totally worth it, I basically picked it up again. The solution to the bug fix differs from mine, though. I think we can safely abandon this patch and follow-up on the other one.
  25. Christian Kuhn abandoned the change 09/23/20, 13:59