Review main Merged Breaking

47483[!!!][TASK] Make TYPO3_CONF_VARS[BE][lockSSL] boolean

Benni Mack CR +2 V +2 Normal +63 −18 updated 04/01/16, 13:21

Commit message

The lockSSL setting has three possible values:
0 = do nothing when in the backend
1 = show a blank page when accessing the BE from non-SSL
2 = redirect to the https version of the BE

The option "1" is nowadays not a valuable option and
"hiding" the TYPO3 Backend can be done via htaccess
or other access rules.

Therefore the lockSSL setting only has a bool state now:
 * When false do nothing
 * When true, redirect to the SSL version of the BE

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Daniel Goerz +1
    • Morton Jonuschat +1
  • Verified V +2
    • Christian Kuhn +2
    • Morton Jonuschat +1

Issues 1

Files 6

Review log 10

  1. Benni Mack uploaded patch set 1 04/01/16, 09:40

  2. Benni Mack commented on patch set 1 CR -1 04/01/16, 10:11

    working on it
  3. Benni Mack uploaded patch set 2 04/01/16, 10:43

  4. Morton Jonuschat voted on patch set 2 CR +1 V +1 04/01/16, 11:38

  5. Daniel Goerz commented on patch set 2 04/01/16, 13:13

    SilentConfigurationUpgradeService.php:643

    Shouldn't we cast (int) here?
  6. Morton Jonuschat commented on patch set 3 04/01/16, 13:19

    Published edit on patch set 2.
  7. Morton Jonuschat voted on patch set 3 CR +1 V +1 04/01/16, 13:19

  8. Daniel Goerz voted on patch set 3 CR +1 04/01/16, 13:20

  9. Christian Kuhn voted on patch set 3 CR +2 V +2 04/01/16, 13:21

  10. Gerrit merged patch set 3 04/01/16, 13:21