Review main Merged

47491[TASK] Flexform support for type:passthrough

Frank Nägler CR +2 V +2 Easy +16 −1 updated 09/29/17, 13:28

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Frank Nägler +1
  • Verified V +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 2843

Show 1218 earlier messages
  1. Frank Nägler uploaded patch set 1 04/01/16, 14:08

  2. TYPO3com voted on patch set 1 V -1 12/04/16, 11:32 Completed build in 33m 01s on Sun, 4 Dec, 12:32 PM Test Summary: 54322 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5481

  3. Frank Nägler uploaded patch set 2 08/18/17, 07:57

  4. TYPO3com voted on patch set 2 V -1 08/18/17, 07:57 Completed build in 16s on Fri, 18 Aug, 09:57 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13797

  5. Frank Nägler uploaded patch set 3 08/18/17, 07:58

  6. Frank Nägler updated the commit message in patch set 4 08/18/17, 07:59

  7. TYPO3com voted on patch set 3 V +1 08/18/17, 08:11 Completed build in 12m 34s on Fri, 18 Aug, 10:11 AM Test Summary: 57575 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13798

  8. TYPO3com voted on patch set 4 V +1 08/18/17, 08:19 Completed build in 19m 27s on Fri, 18 Aug, 10:19 AM Test Summary: 57575 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13799

  9. Georg Ringer voted on patch set 4 CR +1 V +1 08/29/17, 05:31

  10. Jörg Bösche voted on patch set 4 CR +1 08/29/17, 06:22

  11. Christian Kuhn updated the commit message in patch set 5 08/31/17, 13:25

  12. Christian Kuhn commented on patch set 5 08/31/17, 13:25

    not v7 anymore, please.
  13. Christian Kuhn commented on patch set 5 CR -1 08/31/17, 13:33

    FlexFormElementContainer.php:139

    I'd rather change that to an early return if type===passthrough, similar to the early return in SingleFieldContainer. this way it's in-line with that container, and we don't need the PassthroughElement at all.

    PassthroughElement.php:40

    this method implementation should be obsolete.

    DataHandler.php:3113

    what is that good for? shouldn't passthrough pick any value incoming from form, too?
  14. TYPO3com voted on patch set 5 V -1 08/31/17, 13:49 Completed build in 24m 08s on Thu, 31 Aug, 03:49 PM Test Summary: 1 of 58207 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14127

  15. Frank Nägler uploaded patch set 6 09/19/17, 14:39

  16. Frank Nägler commented on patch set 6 CR -1 09/19/17, 14:44

    wait for lolli ;)
  17. TYPO3com voted on patch set 6 V +1 09/19/17, 15:01 Completed build in 22m 28s on Tue, 19 Sep, 05:01 PM Test Summary: 58206 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15043

  18. Frank Nägler uploaded patch set 7 09/29/17, 11:38

  1. TYPO3com voted on patch set 7 V +1 09/29/17, 11:51 Completed build in 12m 53s on Fri, 29 Sep, 01:51 PM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15192

  2. Frank Nägler uploaded patch set 8 09/29/17, 11:56

  3. Frank Nägler uploaded patch set 9 09/29/17, 11:57

  4. TYPO3com voted on patch set 9 V +1 09/29/17, 12:07 Completed build in 09m 36s on Fri, 29 Sep, 02:07 PM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15194

  5. TYPO3com voted on patch set 8 V -1 09/29/17, 12:09 Completed build in 12m 56s on Fri, 29 Sep, 02:09 PM Test Summary: 1 of 57122 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15193

  6. Christian Kuhn uploaded patch set 10 09/29/17, 12:16

  7. Christian Kuhn uploaded patch set 11 09/29/17, 12:22

  8. TYPO3com voted on patch set 10 V +1 09/29/17, 12:30 Completed build in 13m 51s on Fri, 29 Sep, 02:30 PM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15195

  9. TYPO3com voted on patch set 11 V +1 09/29/17, 12:35 Completed build in 13m 11s on Fri, 29 Sep, 02:35 PM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15196

  10. Stefan Neufeind commented on patch set 11 09/29/17, 12:52

    DataHandler.php:3088

    Do we need to take care of the !is_array($dsConf['TCEforms']['config']) as per the if-statement below? I mean move that if-statement above here?
  11. Christian Kuhn commented on patch set 11 09/29/17, 12:55

    DataHandler.php:3088 Reply

    no, won't work, default values wouldn't be applied then.
  12. Christian Kuhn uploaded patch set 12 09/29/17, 13:02

  13. TYPO3com voted on patch set 12 V -1 09/29/17, 13:02 Completed build in 08s on Fri, 29 Sep, 03:02 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15197

  14. Christian Kuhn uploaded patch set 13 09/29/17, 13:03

  15. Christian Kuhn uploaded patch set 14 09/29/17, 13:05

  16. TYPO3com voted on patch set 13 V -1 09/29/17, 13:12 Completed build in 09m 18s on Fri, 29 Sep, 03:12 PM Test Summary: 1 of 57122 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15198

  17. Stefan Neufeind commented on patch set 14 V +1 09/29/17, 13:14

    tested with flexform of EXT:news and a field set to passthrough with a default-value
  18. TYPO3com voted on patch set 14 V -1 09/29/17, 13:18 Completed build in 13m 01s on Fri, 29 Sep, 03:18 PM Test Summary: 1 of 57122 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15199

  19. Frank Nägler voted on patch set 14 CR +1 V +1 09/29/17, 13:23

  20. Christian Kuhn commented on patch set 14 09/29/17, 13:23

    @Stefan: we added some examples to ext:styleguide to test that, too.
  21. TYPO3com voted on patch set 14 V +1 09/29/17, 13:23 Completed build in 30m 54s on Fri, 29 Sep, 03:23 PM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15199

  22. Stefan Neufeind voted on patch set 14 CR +1 09/29/17, 13:27

  23. Christian Kuhn voted on patch set 14 CR +1 V +1 09/29/17, 13:27

  24. Christian Kuhn voted on patch set 14 CR +2 V +2 09/29/17, 13:28

  25. Gerrit merged patch set 14 09/29/17, 13:28