Review main Merged

47492[BUGFIX] Do not escape output of IconViewHelper

Markus Klein CR +2 V +2 Easy +8 −1 updated 04/07/16, 13:33

Commit message

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Wouter Wolters +1
  • Verified V +2
    • Helmut Hummel +2
    • Wouter Wolters +1

Issues 1

Files 1

Review log 14

  1. Markus Klein uploaded patch set 1 04/01/16, 17:06

  2. Daniel Goerz voted on patch set 1 CR +1 V +1 04/01/16, 18:54

  3. Markus Klein commented on patch set 1 CR -2 04/01/16, 19:22

    investigating something.
  4. Helmut Hummel commented on patch set 1 CR +1 04/03/16, 21:01

    Son't know what you need to investigate, but the code looks correct.

    IconViewHelper.php:29

    because $iconFactory->getIcon() can return HTML, setting $escapeOutput to false is correct
  5. Markus Klein voted on patch set 1 CR 0 04/04/16, 23:16

  6. Benni Mack commented on patch set 1 CR -2 04/05/16, 04:16

    I think we have one or two more occurrences, I will recheck that for the time being at get back to you on that.
  7. Wouter Wolters voted on patch set 1 CR +1 V +1 04/07/16, 12:17

  8. Wouter Wolters commented on patch set 2 04/07/16, 12:21

    Published edit on patch set 1.
  9. Wouter Wolters voted on patch set 2 CR +1 V +1 04/07/16, 12:21

  10. Helmut Hummel uploaded patch set 3 04/07/16, 12:21

  11. Helmut Hummel commented on patch set 3 CR +2 V +2 04/07/16, 12:22

    @Benni: Lets get this in please!
  12. Wouter Wolters voted on patch set 3 CR +1 V +1 04/07/16, 12:23

  13. Benni Mack voted on patch set 3 CR 0 04/07/16, 13:33

  14. Gerrit merged patch set 3 04/07/16, 13:33