Review main Merged

47494[BUGFIX] Make ImageService Exception more descriptive

Benni Mack CR +2 V +2 Easy +1 −1 updated 04/01/16, 19:03

Commit message

The Extbase FAL ImageService throws an exception if the src
parameter is not resolved to a proper File/FileReference object.

The patch adds the $src parameter to the Exception message
in order to detect in an easier way where something went
wrong.

Review

  • Code review CR +2
    • Markus Klein +2
    • Daniel Goerz +1
  • Verified V +2
    • Markus Klein +2
    • Daniel Goerz +1

Issues 1

Files 1

Review log 6

  1. Benni Mack uploaded patch set 1 04/01/16, 18:36

  2. Markus Klein voted on patch set 1 CR +1 V +1 04/01/16, 18:54

  3. Daniel Goerz voted on patch set 1 CR +1 V +1 04/01/16, 19:01

  4. Markus Klein voted on patch set 1 CR +2 V +2 04/01/16, 19:03

  5. Gerrit merged patch set 1 04/01/16, 19:03

  6. Markus Klein commented on patch set 2 04/01/16, 19:03

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 1b1b2f8fad740a32fa05cba3cf908ac3f41b77b8