Review main Merged

47507[BUGFIX] Raise index_rel.first to int(11)

Benni Mack CR +2 V +2 Easy +1 −1 updated 04/07/16, 11:34

Commit message

The index_rel.first database table of indexed_search
is used to store the number of occurrences of words,
which could be more in bigger indices.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Georg Ringer +1
    • Tymoteusz Motylewski +1
  • Verified V +2
    • Christian Kuhn +2
    • Georg Ringer +1
    • Tymoteusz Motylewski +1

Issues 1

Files 1

Review log 14

  1. Benni Mack uploaded patch set 1 04/05/16, 09:29

  2. Wouter Wolters voted on patch set 1 CR +1 V +1 04/05/16, 09:32

  3. Christian Kuhn commented on patch set 1 04/05/16, 10:26

    do we really really really must have a ext_tables.sql change still in 6.2 at this point in time, even if it is only making a field bigger in size?
  4. Benni Mack commented on patch set 1 04/05/16, 10:32

    well, I verified it that it was broken in one of our bigger projects with 6.2, I don't need to have it personally there. will update accordingly.
  5. Benni Mack updated the commit message in patch set 2 04/05/16, 10:32

  6. Tymoteusz Motylewski commented on patch set 2 CR +1 V +1 04/05/16, 11:08

    looks good to me, It would be nice if you could change other fields suffering from the same issue.
  7. Tymoteusz Motylewski commented on patch set 2 04/05/16, 11:09

    I also have an 6.2 installation affected by this.
  8. Georg Ringer voted on patch set 2 CR +1 V +1 04/05/16, 12:20

  9. Benni Mack commented on patch set 2 04/05/16, 15:33

    hey tymek, which ones should be considered as well? The others did not bloat up on my 6.2 installation as far as I checked.
  10. Tymoteusz Motylewski commented on patch set 2 04/05/16, 15:58

    unsigned tinyint max value is 256 right? So with bigger documents you chan reach that value in "count". Just checked freq and we have a hardcoded upper limit of "32000" so it should be ok with unsigned smallint (65535) flags is a bitmask field, so it also OK
  11. Morton Jonuschat commented on patch set 2 04/05/16, 16:40

    UNSIGNED TINYINT is 0-255, SMALLINT is 0-65535 and INT is 0-16777215
  12. Christian Kuhn voted on patch set 2 CR +2 V +2 04/07/16, 11:33

  13. Gerrit merged patch set 2 04/07/16, 11:33

  14. Christian Kuhn commented on patch set 3 04/07/16, 11:34

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 4ba02f3dfe29994a789603fe0d3500894b8b10ed