47524[BUGFIX] Fix escaped output of fluid_styled_content ViewHelpers
Commit message
Review
-
Code review CR +2
- Helmut Hummel +2
- Daniel Goerz +1
- Nicole Hummel +1
-
Verified V +2
- Helmut Hummel +2
- Daniel Goerz +1
- Riccardo De Contardi +1
- Nicole Hummel +1
Issues 1
Files 6
- typo3/sysext/fluid_styled_content/Classes/ViewHelpers/Menu/CategoriesViewHelper.php+7 −0
- typo3/sysext/fluid_styled_content/Classes/ViewHelpers/Menu/DirectoryViewHelper.php+7 −0
- typo3/sysext/fluid_styled_content/Classes/ViewHelpers/Menu/KeywordsViewHelper.php+7 −0
- typo3/sysext/fluid_styled_content/Classes/ViewHelpers/Menu/ListViewHelper.php+7 −0
- typo3/sysext/fluid_styled_content/Classes/ViewHelpers/Menu/SectionViewHelper.php+7 −0
- typo3/sysext/fluid_styled_content/Classes/ViewHelpers/Menu/UpdatedViewHelper.php+7 −0
Review log 10
-
Wouter Wolters uploaded patch set 1 04/06/16, 21:01
-
Christian Kuhn commented on patch set 1 CR -1 04/07/16, 10:53
to my understanding, this is not ok. had a chat with benni in this area some days ago, would be great if he could have a look. -
Helmut Hummel commented on patch set 1 CR +1 V +1 04/07/16, 12:05
This patch is totally correct! All these view helpers return the result of rendered children, which of course most likely will contain HTML. having output ecoding enabled, will encode the HTML structures, which is not wanted here. Setting esacpeOutput to false is absolutely correct here! -
Christian Kuhn commented on patch set 1 CR 0 04/07/16, 12:13
thx helmut. removed my -1 again. -
Nicole Hummel uploaded patch set 2 04/07/16, 19:23
-
Nicole Hummel commented on patch set 2 CR +1 V +1 04/07/16, 19:24
Just added some comments why the escaping is disabled -
Daniel Goerz voted on patch set 2 CR +1 V +1 04/07/16, 20:37
-
Riccardo De Contardi voted on patch set 2 V +1 04/07/16, 20:42
-
Helmut Hummel voted on patch set 2 CR +2 V +2 04/07/16, 22:09
-
Gerrit merged patch set 2 04/07/16, 22:09