Review main Merged

47528[BUGFIX] Only focus RTE if current focus is on body tag

Andreas Kienast CR +2 V +2 Easy +5 −0 updated 05/06/16, 07:56

Commit message

Focus the RTE (or its textarea fallback) only if the current focus
is on the body tag, which is the default after loading a page.
This prevents focus stealing if the focus is e.g. on an input field
before the RTE was initialized.

Review

  • Code review CR +2
    • Markus Klein +2
    • Frank Nägler +1
  • Verified V +2
    • Markus Klein +2
    • Frank Nägler +1

Issues 1

Files 1

Review log 23

  1. Andreas Kienast uploaded patch set 1 04/07/16, 08:09

  2. Andreas Kienast commented on patch set 2 04/07/16, 08:13

    Published edit on patch set 1.
  3. Andreas Kienast uploaded patch set 3 04/07/16, 08:13

  4. Mathias Schreiber updated the commit message in patch set 4 04/07/16, 08:29

  5. Felix Rauch voted on patch set 4 CR +1 04/07/16, 08:49

  6. Daniel Goerz commented on patch set 4 CR +1 V +1 04/07/16, 09:09

    Man that was anoying :)
  7. Andreas Kienast commented on patch set 4 CR -1 04/07/16, 09:41

    working on it
  8. Daniel Goerz voted on patch set 4 CR 0 V 0 04/07/16, 20:41

  9. Frank Nägler commented on patch set 4 04/08/16, 11:54

    Editor.js:509

    In case of stupid browsers or future changes, the check should be changed to: if (document.activeElement.tagName.toLowerCase() !== 'body')
  10. Frank Nägler uploaded patch set 5 04/08/16, 12:15

  11. Frank Nägler voted on patch set 5 CR +1 V +1 04/08/16, 12:16

  12. Markus Klein commented on patch set 5 V -1 04/08/16, 12:35

    Does not work for me. I test like this: - I open an existing textmedia record. - I click on the (still empty) title field - The data is filled into the title field (the cursor is at the end of the field) - Focus is removed from the field somehow - RTE initializes - Focus jumps into the RTE
  13. Gianluigi Martino commented on patch set 5 V -1 04/08/16, 12:43

    Same as Markus Klein
  14. Gianluigi Martino rebased onto patch set 6 04/08/16, 13:24

  15. Riccardo De Contardi commented on patch set 6 V +1 04/08/16, 13:53

    It seems to work for me (tested on Chrome, MAC): before the test I cleared the browser cache and the cache from Install Tool.
  16. Peter Foerger voted on patch set 6 CR +1 05/03/16, 14:44

  17. Nicole Hummel voted on patch set 6 CR +1 05/04/16, 21:39

  18. Nicole Hummel commented on patch set 6 05/04/16, 21:39

    an
  19. Andreas Kienast updated the commit message in patch set 7 05/05/16, 07:02

  20. Frank Nägler voted on patch set 7 CR +1 V +1 05/05/16, 19:45

  21. Markus Klein commented on patch set 7 CR +2 V +2 05/06/16, 07:56

    Works. Thank you very much.
  22. Gerrit merged patch set 7 05/06/16, 07:56

  23. Markus Klein commented on patch set 8 05/06/16, 07:56

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 8d51a946a981476054ef72a6fe1952670b2315b3