Review main Merged

47537[TASK] Update adodb to v5.20.3

Christian Kuhn CR +2 V +2 Impossible +6318 −4526 updated 04/08/16, 07:47

Commit message

This brings a list of bug fixes and better PHP7 compatibility.
This is a "hacked" version from vanilla 5.20.3 where some
local changes are applied that were not yet fixed upstream,
see forge for a diff.

Review

  • Code review CR +2
    • Morton Jonuschat +2
    • Daniel Goerz +1
    • Frank Nägler +1
  • Verified V +2
    • Morton Jonuschat +2
    • Frank Nägler +1

Issues 1

Files 144

Show 124 more files

Review log 9

  1. Christian Kuhn uploaded patch set 1 04/07/16, 16:59

  2. Christian Kuhn commented on patch set 1 04/07/16, 17:02

    hint: primary target is not master here since adodb will hopefully vanish soon, but this is mostly thought for 7.6.
  3. Morton Jonuschat commented on patch set 1 CR +1 V +1 04/07/16, 17:55

    Verified using DBAL native MySQL, DBAL MySQLi & DBAL PostgreSQL. Operations like create/select/update/delete work across all drivers with common record types. Clean Install on PostgreSQL works.
  4. Christian Kuhn commented on patch set 1 04/07/16, 18:12

  5. Daniel Goerz voted on patch set 1 CR +1 04/07/16, 20:38

  6. Frank Nägler commented on patch set 1 CR +1 V +1 04/08/16, 07:45

    verify by unit and functional tests. unit tests: Time: 38,63 seconds, Memory: 372,00Mb OK, but incomplete, skipped, or risky tests! Tests: 8136, Assertions: 10691, Skipped: 168, Incomplete: 1. functional tests: Time: 6.38 minutes, Memory: 14.00Mb OK, but incomplete, skipped, or risky tests! Tests: 816, Assertions: 11548, Skipped: 4.
  7. Morton Jonuschat voted on patch set 1 CR +2 V +2 04/08/16, 07:47

  8. Gerrit merged patch set 1 04/08/16, 07:47

  9. Morton Jonuschat commented on patch set 2 04/08/16, 07:47

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 82321d7430db958071bc3773a276970bb21e77cc