47541[TASK] Use ext:styleguide in acceptance tests
Commit message
Review
-
Code review CR +2
- Susi Moog +2
- Sascha Egerer +1
-
Verified V +2
- Susi Moog +2
- Sascha Egerer +1
Issues 1
Files 4
Review log 20
-
Christian Kuhn uploaded patch set 1 04/07/16, 21:00
-
Christian Kuhn voted on patch set 1 CR -2 04/07/16, 21:00
-
Christian Kuhn updated the commit message in patch set 2 04/07/16, 21:01
-
Christian Kuhn uploaded patch set 3 04/09/16, 19:44
-
Christian Kuhn uploaded patch set 4 04/10/16, 13:16
-
Christian Kuhn uploaded patch set 5 04/11/16, 09:21
-
Georg Ringer commented on patch set 5 04/11/16, 10:05
can we move then styleguide then to a different github repo? -
Christian Kuhn uploaded patch set 6 04/11/16, 10:19
-
Christian Kuhn voted on patch set 6 CR 0 04/11/16, 10:19
-
Christian Kuhn commented on patch set 6 04/11/16, 10:24
finally ready now. -
Sascha Egerer commented on patch set 6 04/11/16, 11:04
What about the question from Georg?AcceptanceCoreEnvironment.php:181Do we have a cgl for the short array notation? I would remove the spacesAcceptanceCoreEnvironment.php:240This comment is hard to understandAcceptanceCoreEnvironment.php:241What about moving that in an test helper function? I think we may need that on other places too -
Christian Kuhn commented on patch set 6 04/11/16, 11:51
AcceptanceCoreEnvironment.php:181Replyno, we don't have a hard rule for that, can be kept as is.AcceptanceCoreEnvironment.php:241Replyi'd keep that for the time being. -
Christian Kuhn uploaded patch set 7 04/11/16, 11:53
-
Sascha Egerer commented on patch set 7 CR +1 V +1 04/11/16, 12:14
works on my machine... -
Christian Kuhn commented on patch set 7 04/11/16, 12:18
catharsis green: https://travis-ci.org/lolli42/TYPO3.CMS-Catharsis/builds/122229408 -
Christian Kuhn uploaded patch set 8 04/11/16, 12:19
-
Susi Moog voted on patch set 8 CR +1 V +1 04/11/16, 12:20
-
Sascha Egerer voted on patch set 8 CR +1 V +1 04/11/16, 12:20
-
Susi Moog voted on patch set 8 CR +2 V +2 04/11/16, 12:21
-
Gerrit merged patch set 8 04/11/16, 12:22