Review main Merged

47541[TASK] Use ext:styleguide in acceptance tests

Christian Kuhn CR +2 V +2 Normal +75 −7 updated 04/11/16, 12:22

Commit message

Adds styleguide as require-dev composer dependency and
call the data generator for acceptance tests.

Review

  • Code review CR +2
    • Susi Moog +2
    • Sascha Egerer +1
  • Verified V +2
    • Susi Moog +2
    • Sascha Egerer +1

Issues 1

Files 4

Review log 20

  1. Christian Kuhn uploaded patch set 1 04/07/16, 21:00

  2. Christian Kuhn voted on patch set 1 CR -2 04/07/16, 21:00

  3. Christian Kuhn updated the commit message in patch set 2 04/07/16, 21:01

  4. Christian Kuhn uploaded patch set 3 04/09/16, 19:44

  5. Christian Kuhn uploaded patch set 4 04/10/16, 13:16

  6. Christian Kuhn uploaded patch set 5 04/11/16, 09:21

  7. Georg Ringer commented on patch set 5 04/11/16, 10:05

    can we move then styleguide then to a different github repo?
  8. Christian Kuhn uploaded patch set 6 04/11/16, 10:19

  9. Christian Kuhn voted on patch set 6 CR 0 04/11/16, 10:19

  10. Christian Kuhn commented on patch set 6 04/11/16, 10:24

    finally ready now.
  11. Sascha Egerer commented on patch set 6 04/11/16, 11:04

    What about the question from Georg?

    AcceptanceCoreEnvironment.php:181

    Do we have a cgl for the short array notation? I would remove the spaces

    AcceptanceCoreEnvironment.php:240

    This comment is hard to understand

    AcceptanceCoreEnvironment.php:241

    What about moving that in an test helper function? I think we may need that on other places too
  12. Christian Kuhn commented on patch set 6 04/11/16, 11:51

    AcceptanceCoreEnvironment.php:181 Reply

    no, we don't have a hard rule for that, can be kept as is.

    AcceptanceCoreEnvironment.php:241 Reply

    i'd keep that for the time being.
  13. Christian Kuhn uploaded patch set 7 04/11/16, 11:53

  14. Sascha Egerer commented on patch set 7 CR +1 V +1 04/11/16, 12:14

    works on my machine...
  15. Christian Kuhn commented on patch set 7 04/11/16, 12:18

  16. Christian Kuhn uploaded patch set 8 04/11/16, 12:19

  17. Susi Moog voted on patch set 8 CR +1 V +1 04/11/16, 12:20

  18. Sascha Egerer voted on patch set 8 CR +1 V +1 04/11/16, 12:20

  19. Susi Moog voted on patch set 8 CR +2 V +2 04/11/16, 12:21

  20. Gerrit merged patch set 8 04/11/16, 12:22