Review main Merged

47545[TASK] Enable output of file names in DebugUtility::debugTrail

Daniel Goerz CR +2 V +2 Easy +4 −2 updated 04/13/16, 08:09

Commit message

Review

  • Code review CR +2
    • Frank Nägler +2
    • Susi Moog +1
  • Verified V +2
    • Frank Nägler +2
    • Susi Moog +1

Issues 1

Files 1

Review log 8

  1. Daniel Goerz uploaded patch set 1 04/08/16, 09:22

  2. Nicole Hummel commented on patch set 1 V -1 04/08/16, 10:48

    DebugUtility.php:141

    This doesn't work if the file points to a symlinked target (symlinked typo3 core)
  3. Daniel Goerz commented on patch set 1 04/08/16, 11:22

    DebugUtility.php:141 Reply

    Then no stripping I guess. Fair enough. Still serves the purpose (only with longer file names :) ) Or is there a better solution?
  4. Daniel Goerz uploaded patch set 2 04/08/16, 11:26

  5. Daniel Goerz updated the commit message in patch set 3 04/12/16, 08:03

  6. Susi Moog voted on patch set 3 CR +1 V +1 04/12/16, 08:14

  7. Frank Nägler voted on patch set 3 CR +2 V +2 04/13/16, 08:05

  8. Gerrit merged patch set 3 04/13/16, 08:09