Review main Merged

47547[FOLLOWUP][BUGFIX] Disable children escaping in CropViewHelper

Nicole Hummel CR +2 V +2 Easy +2 −2 updated 04/11/16, 10:38

Commit message

Currently the CropViewHelper is not able to return HTML as the output
is always escaped. This patch corrects escaping for children and output.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Stefan Neufeind +1
  • Verified V +2
    • Helmut Hummel +2

Issues 2

Files 1

Review log 4

  1. Nicole Hummel uploaded patch set 1 04/08/16, 10:29

  2. Helmut Hummel commented on patch set 1 CR +2 V +2 04/08/16, 12:28

    Here is why I was wrong when disabling children escaping initially: I assumed that this crop view helper had a $value argument which would accept values as alternative to rendering the children. In such a case, we would have to have disabled children escaping and escape everything on output, because in any case the values given as argument to a view helper are never escaped. However, this crop vh (in contrast to the one in Flow) does not accept a value argument and additonally is able to crop HTML content. As such, we must be able to encode variables during rendering of the children and *not* on output. Hope this clears things up a bit. Sorry for the hassle
  3. Stefan Neufeind voted on patch set 1 CR +1 04/09/16, 19:59

  4. Gerrit merged patch set 1 04/11/16, 10:38