Review main Abandoned

47553[TASK] Add phpunit-randomizer to require-dev in composer.json

Jan Helke CR 0 V 0 Normal +51 −3 updated 04/10/16, 18:03

Commit message

After applying this patch you can use the randomizer additionally
to phpunit. This randomizes the order the unit tests will be executed
on a phpunit run. This reveals cross dependencies between unit
tests.

So during your develoment you can use phpunit to execute your unit
test as usual. After you finished the development, run the randomizer

./bin/phpunit-randomizer -d memory_limit=-1 -c \
    typo3/sysext/core/Build/UnitTests.xml $* --order rand

After finishing you'll find the seed used to produce this particular
order (e.g. 1234). If you spot any errors during the randomizing, you
can use this seed to reproduce the order.

./bin/phpunit-randomizer -d memory_limit=-1 -c \
     typo3/sysext/core/Build/UnitTests.xml $* --order rand:1234

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 5

  1. Jan Helke uploaded patch set 1 04/10/16, 13:31

  2. Anja Leichsenring updated the commit message in patch set 2 04/10/16, 13:35

  3. Anja Leichsenring voted on patch set 2 CR +1 V +1 04/10/16, 13:35

  4. Christian Kuhn commented on patch set 2 CR -1 04/10/16, 15:45

    i'm against adding this dependency to the core: there is no benefit for everyone and it is probably not a good idea to add it to travis, too: it will make the test runs after a merge less deterministic. after talking with susi we think the important parts in this patch set are rather a documententation (wiki of unit test page?) to document: do "composer require .../phpunit-random" and then use that command to execute it. the randomizer is a thing that could run once and then for a night, but it is not necessarily part of our build.
  5. Jan Helke abandoned the change 04/10/16, 18:03

    Documentation done in the wiki.