47564[TASK] Install PhantomJS via composer and add codeception integration
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Daniel Goerz +1
- Susi Moog +1
-
Verified V +2
- Christian Kuhn +2
- Susi Moog +1
Issues 1
Files 5
Review log 16
-
Sascha Egerer uploaded patch set 1 04/11/16, 10:41
-
Sascha Egerer uploaded patch set 2 04/11/16, 12:32
-
Sascha Egerer uploaded patch set 3 04/11/16, 13:18
-
Susi Moog commented on patch set 3 V -1 04/12/16, 07:50
bitbucket authentication is strange, additionally: Starting PhantomJS Server Warning: proc_open(): CreateProcess failed, error code - 87 in C:\inetpub\wwwroot\Projects\Core\vendor\site5\phantoman\src\Phantoman.php on line 108 Warning: proc_close() expects parameter 1 to be resource, boolean given in C:\inetpub\wwwroot\Projects\Core\vendor\site5\phantoman\src\Phantoman.php on line 111 [Codeception\Exception\ExtensionException] Codeception\Extension\Phantoman Failed to start PhantomJS server. -
Sascha Egerer commented on patch set 3 04/12/16, 07:53
I think thats an API rate limit. How does the output look like? -
Susi Moog commented on patch set 3 CR +1 V +1 04/12/16, 07:58
just installed again! now it works. -
Daniel Goerz voted on patch set 3 CR +1 04/12/16, 08:43
-
Sascha Egerer uploaded patch set 4 04/12/16, 17:50
-
Sascha Egerer uploaded patch set 5 04/12/16, 17:51
-
Sascha Egerer commented on patch set 5 04/12/16, 17:53
composer.json:61My pull request for the package has been merges and released as 2.1.1.-01. So i could remove the `ext-bz2` dependency from the composer.json as it is not added to that package. We can't change that version to something like ~2.1 as it looks like the installer script uses this version somehow to download the phantomjs version... Thats a little bit ugly but... it works... -
Christian Kuhn uploaded patch set 6 04/12/16, 18:09
-
Susi Moog voted on patch set 6 CR +1 V +1 04/12/16, 18:21
-
Daniel Goerz voted on patch set 6 CR +1 04/12/16, 18:30
-
Christian Kuhn voted on patch set 6 CR +2 V +2 04/12/16, 19:24
-
Gerrit merged patch set 6 04/12/16, 19:24
-
Nicole Hummel commented on patch set 7 04/12/16, 21:06
Post -1 - this patch adds a new PHP requirement which wasn't mentioned int this patch: Problem 1 - Installation request for jakoch/phantomjs-installer 2.1.1-p01 -> satisfiable by jakoch/phantomjs-installer[2.1.1-p01]. - jakoch/phantomjs-installer 2.1.1-p01 requires ext-bz2 * -> the requested PHP extension bz2 is missing from your system.