Review main Merged

47588[BUGFIX] Prevent fatal error when uploading file with invalid filename

Arjen Hoekema CR +2 V +2 Easy +19 −19 updated 04/13/16, 08:20

Commit message

The call to "addMessageToFlashMessageQueue" expects the second argument
to be an array instead of a string.
Additionally the type of the fifth argument of writeLog() has been corrected
troughout the class.

Review

  • Code review CR +2
    • Susi Moog +2
    • Daniel Goerz +1
    • Arjen Hoekema +1
    • Michael Oehlhof +1
  • Verified V +2
    • Susi Moog +2
    • Daniel Goerz +1
    • Arjen Hoekema +1

Issues 1

Files 1

Review log 12

  1. Arjen Hoekema uploaded patch set 1 04/12/16, 07:38

  2. Daniel Goerz commented on patch set 1 CR -1 04/12/16, 08:00

    Hi, I just saw two things: 1. A lot of calls in this class are using the wrong type for these arguments, we should fix them all. The issue is the same in 7.6. We shuld backport the fix. Would you like to update the patch yourself or should I push a new patch set? Temp -1
  3. Arjen Hoekema commented on patch set 1 04/12/16, 08:14

    I checked the other calls to this method, but could not find any other call without an array as second argument.
  4. Daniel Goerz commented on patch set 1 04/12/16, 08:21

    Sorry I was talking about the writeLog() calls.
  5. Daniel Goerz commented on patch set 1 04/12/16, 08:24

    I'll update th patch
  6. Daniel Goerz uploaded patch set 2 04/12/16, 08:34

  7. Daniel Goerz voted on patch set 2 CR +1 V +1 04/12/16, 08:38

  8. Michael Oehlhof voted on patch set 2 CR +1 04/12/16, 08:47

  9. Arjen Hoekema voted on patch set 2 CR +1 V +1 04/12/16, 09:04

  10. Susi Moog voted on patch set 2 CR +2 V +2 04/13/16, 08:19

  11. Gerrit merged patch set 2 04/13/16, 08:19

  12. Susi Moog commented on patch set 3 04/13/16, 08:20

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit e7ba50c667717e024df53b96d999b5e96109b6ce