Review main Merged

47634[TASK] Refactor page module acceptance tests

Sascha Egerer CR +2 V +2 Easy +23 −17 updated 04/13/16, 08:09

Commit message

The page module acceptance test should use the admin actor.

Review

  • Code review CR +2
    • Susi Moog +2
    • Dirk Jüttner +1
  • Verified V +2
    • Susi Moog +2
    • Dirk Jüttner +1

Issues 1

Files 2

Review log 10

  1. Sascha Egerer uploaded patch set 1 04/12/16, 20:08

  2. Dirk Jüttner voted on patch set 1 CR +1 V +1 04/12/16, 20:25

  3. Susi Moog commented on patch set 1 V -1 04/12/16, 20:29

    fails with phantom
  4. Sascha Egerer commented on patch set 1 CR -2 04/12/16, 20:44

    Looks like the addCookie function in the current phantomjs version is broken but will be fixed in the next release... https://github.com/ariya/phantomjs/issues/14047
  5. Sascha Egerer uploaded patch set 2 04/12/16, 20:58

  6. Sascha Egerer commented on patch set 2 CR 0 04/12/16, 20:59

    I've added a workaround for the PhantomJS bug that can be removed when the new PhantomJS version is released.
  7. Sascha Egerer commented on patch set 3 04/12/16, 21:01

    Published edit on patch set 2.
  8. Dirk Jüttner commented on patch set 3 CR +1 V +1 04/12/16, 21:06

    Now it works on firefox and (!) phantomjs
  9. Susi Moog voted on patch set 3 CR +2 V +2 04/13/16, 08:08

  10. Gerrit merged patch set 3 04/13/16, 08:09