47644[TASK] Streamline escaping for ViewHelpers of all sysexts
Commit message
Review
-
Code review CR +2
- Helmut Hummel +2
- Nicole Hummel +1
-
Verified V +2
- Helmut Hummel +2
- Nicole Hummel +1
Issues 1
Files 44
- typo3/sysext/belog/Classes/ViewHelpers/ErrorIconViewHelper.php+7 −0
- typo3/sysext/belog/Classes/ViewHelpers/FormatDetailsViewHelper.php+1 −1
- typo3/sysext/belog/Classes/ViewHelpers/HistoryEntryViewHelper.php+8 −1
- typo3/sysext/belog/Classes/ViewHelpers/UsernameViewHelper.php+2 −2
- typo3/sysext/belog/Classes/ViewHelpers/WorkspaceTitleViewHelper.php+2 −2
- typo3/sysext/beuser/Classes/ViewHelpers/Display/PagesViewHelper.php+7 −0
- typo3/sysext/beuser/Classes/ViewHelpers/Display/SysFileMountsViewHelper.php+7 −0
- typo3/sysext/beuser/Classes/ViewHelpers/Display/SysLanguageViewHelper.php+7 −0
- typo3/sysext/beuser/Classes/ViewHelpers/IssueCommandViewHelper.php2+1 −1
- typo3/sysext/beuser/Classes/ViewHelpers/PermissionsViewHelper.php+16 −9
- typo3/sysext/beuser/Classes/ViewHelpers/RemoveUserViewHelper.php+7 −0
- typo3/sysext/beuser/Classes/ViewHelpers/SpriteIconForRecordViewHelper.php+8 −1
- typo3/sysext/beuser/Classes/ViewHelpers/SwitchUserViewHelper.php+7 −0
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-75575-TranslateViewHelperHtmlEscapeArgumentMarkedAsDeprecated.rstnew+30 −0
- typo3/sysext/documentation/Classes/ViewHelpers/FormatsViewHelper.php+8 −1
- typo3/sysext/extensionmanager/Classes/ViewHelpers/Format/JsonEncodeViewHelper.php1+7 −0
- typo3/sysext/extensionmanager/Classes/ViewHelpers/Typo3DependencyViewHelper.php+7 −0
- typo3/sysext/extensionmanager/Resources/Private/Templates/Download/InstallFromTer.json2+2 −2
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Buttons/CshViewHelper.php1+7 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Buttons/ShortcutViewHelper.php2+7 −0
Show 24 more files
- typo3/sysext/fluid/Classes/ViewHelpers/Be/InfoboxViewHelper.php3+2 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Be/TableListViewHelper.php4+8 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Format/BytesViewHelper.php2+7 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Format/CaseViewHelper.php+7 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Format/CurrencyViewHelper.php1+7 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Format/HtmlentitiesDecodeViewHelper.php+9 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Format/HtmlViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Format/NumberViewHelper.php+7 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Format/PaddingViewHelper.php+7 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Format/UrlencodeViewHelper.php+1 −8
- typo3/sysext/fluid/Classes/ViewHelpers/BaseViewHelper.php+7 −0
- typo3/sysext/fluid/Classes/ViewHelpers/TranslateViewHelper.php2+12 −2
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/TranslateViewHelperTest.php+0 −10
- typo3/sysext/indexed_search/Classes/ViewHelpers/Format/DateTimeViewHelper.php+9 −1
- typo3/sysext/indexed_search/Classes/ViewHelpers/Format/FlagValueViewHelper.php+1 −2
- typo3/sysext/indexed_search/Classes/ViewHelpers/Format/GroupListViewHelper.php+1 −1
- typo3/sysext/indexed_search/Classes/ViewHelpers/PageBrowsingViewHelper.php+8 −1
- typo3/sysext/install/Classes/ViewHelpers/File/ImageDimensionViewHelper.php+8 −0
- typo3/sysext/install/Classes/ViewHelpers/File/RelativePathViewHelper.php+7 −0
- typo3/sysext/install/Classes/ViewHelpers/File/SizeViewHelper.php+8 −0
- typo3/sysext/install/Classes/ViewHelpers/Format/CropViewHelper.php+7 −0
- typo3/sysext/install/Classes/ViewHelpers/Format/ImageMagickCommandsViewHelper.php+9 −2
- typo3/sysext/reports/Classes/ViewHelpers/IconViewHelper.php+7 −0
- typo3/sysext/sys_note/Classes/ViewHelpers/DeleteLinkViewHelper.php+1 −2
Review log 28
Show 3 earlier messages
-
Benni Mack uploaded patch set 1 04/13/16, 13:53
-
Wouter Wolters commented on patch set 1 04/13/16, 14:02
Great Benni, found a few things which I commented.ArrayElementViewHelper.php:25todo?CshViewHelper.php:48whitespaceTableListViewHelper.php:48wrong comment? same below -
Benni Mack commented on patch set 2 04/14/16, 04:50
Published edit on patch set 1.
-
Benni Mack updated the commit message in patch set 3 04/14/16, 04:51
-
Benni Mack uploaded patch set 4 04/14/16, 11:21
-
Benni Mack updated the commit message in patch set 5 04/14/16, 12:46
-
Nicole Hummel commented on patch set 5 04/15/16, 09:52
Just a style question: shouldn't there be an empty line between comment and type annotation. And without the full stop at the end? -
Nicole Hummel commented on patch set 5 CR -1 04/18/16, 17:29
IssueCommandViewHelper.php:77Remove hsc here and the escapeOutput above. No need to escape the output.InfoboxViewHelper.php:65Comment doesn't make sense here. Better to say that the children may contain html which should be output unescaped.TableListViewHelper.php:57I don't see the reason for turning off escaping of child content -
Helmut Hummel commented on patch set 5 CR -2 04/18/16, 19:08
Working on it right now -
Helmut Hummel uploaded patch set 6 04/18/16, 20:57
-
Helmut Hummel commented on patch set 5 04/18/16, 20:57
IssueCommandViewHelper.php:77ReplyDoneJsonEncodeViewHelper.php:29this statement is wrong! It highly depends on the context where the vh is used in, and what we want as default behavior in general. Imho all vhs should escape by default (unless they output HTML of course). Users (template writers) can still influence this behavior!TranslateViewHelper.php:75nope. we should streamline this and deprecate the argument -
Helmut Hummel voted on patch set 6 CR 0 04/18/16, 20:58
-
Helmut Hummel commented on patch set 6 CR -1 04/18/16, 20:58
TranslateViewHelper.php:121we need a deprecation rst now still -
Nicole Hummel commented on patch set 6 CR -1 04/18/16, 22:43
Folder.php:86This doesn't belong to the patch.LocalizationUtility.php:81?InfoboxViewHelper.php:66Please add another new line.TableListViewHelper.php:55Still the question why this is needed? -
Helmut Hummel commented on patch set 6 04/19/16, 12:41
Folder.php:86ReplyDoneLocalizationUtility.php:81ReplyDoneInfoboxViewHelper.php:66Replythis needs to be removed completely. I missed that yesterdayTableListViewHelper.php:55Replygood catch. no rendered children at all here, so we can remove that safelyEscapeChildrenRenderingStandaloneTest.php:18removed this change as well -
Helmut Hummel uploaded patch set 7 04/19/16, 12:52
-
Helmut Hummel uploaded patch set 8 04/19/16, 13:04
-
Nicole Hummel voted on patch set 8 CR +1 V +1 04/19/16, 13:24
-
Nicole Hummel commented on patch set 8 V -1 04/19/16, 13:26
Failing unit test -
Nicole Hummel uploaded patch set 9 04/19/16, 13:28
-
Nicole Hummel voted on patch set 9 CR +1 V +1 04/19/16, 13:40
-
Helmut Hummel uploaded patch set 10 04/19/16, 14:08
-
Nicole Hummel commented on patch set 10 CR -1 04/20/16, 13:51
InstallFromTer.json:2Why is this needed if the escaping for the viewhelper is turned off?ShortcutViewHelper.php:51superfluous spaceBytesViewHelper.php:52The value is excepted to be a number. Why is escaping switched off?CurrencyViewHelper.php:56Value has to be a float. Why do we switch off the escaping here? -
Helmut Hummel uploaded patch set 11 04/20/16, 15:45
-
Helmut Hummel commented on patch set 10 04/20/16, 15:47
InstallFromTer.json:2Replyoutput encoding is on, which is undesired hereShortcutViewHelper.php:51ReplyDoneBytesViewHelper.php:52Replysame as in currency vh, this can/should be off as output encoding is already on. -
Helmut Hummel voted on patch set 11 CR +2 V +2 04/20/16, 15:47
-
Nicole Hummel voted on patch set 11 CR +1 V +1 04/20/16, 15:48
-
Gerrit merged patch set 11 04/20/16, 15:51