47661[BUGFIX] EXT:form - Fix broken inArray validator
Commit message
Review
-
Code review CR +2
- Morton Jonuschat +2
- Daniel Goerz +1
- Daniel Gohlke +1
- Björn Jacob +1
-
Verified V +2
- Morton Jonuschat +2
- Daniel Gohlke +1
- Björn Jacob +1
Issues 1
Files 2
Review log 27
Show 2 earlier messages
-
Björn Jacob voted on patch set 2 V +1 04/14/16, 14:40
-
Nicole Hummel voted on patch set 2 CR +1 04/15/16, 09:49
-
Christian Kuhn commented on patch set 2 CR -1 04/15/16, 10:00
looks as if this could benefit from some unit tests. -
Nicole Hummel commented on patch set 2 04/15/16, 10:09
@lolli: I had a view. There are always unit tests for that IMHO -
Nicole Hummel commented on patch set 2 04/15/16, 10:09
always = already -
Nicole Hummel commented on patch set 2 04/18/16, 21:50
@Christian: any remark? -
Christian Kuhn commented on patch set 2 04/19/16, 10:32
but this is a bugfix. So something should be broken before. Since no unit test was broken before, there was no coverage for the case that is fixed here. Thus, I'd expect additional tests that cover the cases fixed here, or an explanation on what exactly went wrong. -
Christian Kuhn commented on patch set 2 04/19/16, 10:33
all in all that looks as if some details were not properly covered by tests. if you need help here, i may happily step in. -
Björn Jacob commented on patch set 2 04/19/16, 10:35
We will add additional tests. The main problem is that the form wizard generates a different configuration compared to the one which is documented. In the documentation an array notation is recommended. The form wizard itself generates a string. Form version 9 this should be deprecated. -
Benjamin Kott commented on patch set 2 05/04/16, 09:22
hey, whats the status here? -
Marvin Schröder commented on patch set 2 05/12/16, 12:17
Something new here? -
Björn Jacob commented on patch set 2 V 0 06/15/16, 09:40
We're on it, taking care of the unit tests. -
Daniel Gohlke uploaded patch set 3 06/15/16, 10:43
-
Björn Jacob updated the commit message in patch set 4 06/15/16, 10:50
-
Wouter Wolters voted on patch set 4 CR +1 V +1 06/15/16, 13:20
-
Björn Jacob voted on patch set 4 CR +1 V +1 06/16/16, 09:32
-
Morton Jonuschat uploaded patch set 5 06/16/16, 09:46
-
Morton Jonuschat voted on patch set 5 CR +1 V +1 06/16/16, 09:47
-
Björn Jacob voted on patch set 5 CR +1 V +1 06/16/16, 10:56
-
Daniel Gohlke voted on patch set 5 CR -1 V -1 06/16/16, 11:22
-
Daniel Gohlke voted on patch set 5 CR +1 V +1 06/16/16, 11:22
-
Daniel Goerz voted on patch set 5 CR +1 06/16/16, 14:53
-
Morton Jonuschat voted on patch set 5 CR +2 V +2 06/17/16, 05:07
-
Gerrit merged patch set 5 06/17/16, 05:07
-
Morton Jonuschat commented on patch set 6 06/17/16, 05:07
Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 7890721d9309af27a29e13e186945298ea05efbb