47669[TASK] Deprecate GeneralUtility methods
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Christian Kuhn +1
-
Verified V +2
- Georg Ringer +2
- Christian Kuhn +1
Issues 1
Files 6
- typo3/sysext/core/Classes/Cache/Backend/SimpleFileBackend.php+2 −2
- typo3/sysext/core/Classes/Configuration/TypoScript/ConditionMatching/AbstractConditionMatcher.php+2 −1
- typo3/sysext/core/Classes/Utility/GeneralUtility.php11+39 −25
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-75621-GeneralUtilityMethods.rst7new+48 −0
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+1 −1
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+2 −3
Review log 26
Show 1 earlier messages
-
Benni Mack uploaded patch set 1 04/14/16, 15:07
-
Benni Mack uploaded patch set 2 04/14/16, 15:16
-
Benni Mack uploaded patch set 3 04/14/16, 15:32
-
Wouter Wolters commented on patch set 3 04/14/16, 19:29
-
Wouter Wolters uploaded patch set 4 04/14/16, 19:31
-
Wouter Wolters voted on patch set 4 CR +1 V +1 04/14/16, 19:32
-
Christian Kuhn commented on patch set 4 04/14/16, 20:20
on it. -
Christian Kuhn commented on patch set 4 04/14/16, 20:31
looks good to me apart from the remarks by frank.GeneralUtility.php:3197rofl -
Frank Nägler commented on patch set 4 CR -1 04/14/16, 20:43
thx for the great patch, but the two removed params have to throw a deprecation log message.GeneralUtility.php:1529this change must trigger a deprecation messageGeneralUtility.php:3196this change must trigger a deprecation messageDeprecation-75621-GeneralUtilityMethods.rst:20this change must trigger a deprecation messageDeprecation-75621-GeneralUtilityMethods.rst:28should be a : -
Wouter Wolters commented on patch set 4 04/14/16, 20:46
How do you wanna trigger that deprecation message?? -
Christian Kuhn commented on patch set 4 04/14/16, 20:47
GeneralUtility.php:3198not 100% confident with this change.GeneralUtility.php:4207this means false is given to getHostname() ... btw: why? -
Christian Kuhn commented on patch set 4 04/14/16, 20:48
@wouter: initialize variable to null in method argument and throw deprecation if not not null. -
Nicole Hummel commented on patch set 4 04/15/16, 08:39
GeneralUtility.php:701Wouldn't it make sense to have that function in VersionNumberUtility? -
Oliver Hader commented on patch set 4 04/15/16, 08:58
GeneralUtility.php:1146We can use http://php.net/lcfirst directly, can't we?GeneralUtility.php:3198ReplyIt makes sense, however the possibility to enforce using the uname here is disabled. From the point of view how that was used in the core, it looks fine for meGeneralUtility.php:4207ReplyTo avoid using HTTP_HOST, what is undefined in CLI context... thus, these checks were doubled (request type and method parameter)Deprecation-75621-GeneralUtilityMethods.rst:20should be :php:`...` if using RST rolesDeprecation-75621-GeneralUtilityMethods.rst:28should be :php:`...` if using RST rolesDeprecation-75621-GeneralUtilityMethods.rst:30:php: -
Oliver Hader commented on patch set 4 CR -1 04/15/16, 09:00
I'm on it... -
Oliver Hader commented on patch set 4 04/15/16, 09:07
Deprecation-75621-GeneralUtilityMethods.rst:28ReplyDoneDeprecation-75621-GeneralUtilityMethods.rst:30ReplyDone -
Oliver Hader uploaded patch set 5 04/15/16, 09:10
-
Wouter Wolters voted on patch set 5 CR +1 V +1 04/18/16, 14:20
-
Frank Nägler commented on patch set 5 CR -1 04/18/16, 14:24
wrong deprecation messageGeneralUtility.php:3205caling with any parameter or Paramter 1, not Parameter 2 -
Frank Nägler commented on patch set 5 V -1 04/18/16, 14:32
the behavior of GU::getHostname changed with this patch. calling GeneralUtility::getHostname(false) returns: before patch: vagrant.vm after patch: t3.local.typo3.org So I am not sure about this change. -
Benni Mack commented on patch set 5 04/18/16, 19:10
yeah, let's do the deprecations and the breaking changes separately, using the change only for the deprecatoins IMHO. -
Benni Mack uploaded patch set 6 04/19/16, 16:42
-
Benni Mack commented on patch set 4 04/19/16, 16:42
I left the getHostname() stuff untouched for now to get the rest in -
Christian Kuhn voted on patch set 6 CR +1 V +1 04/19/16, 18:22
-
Georg Ringer voted on patch set 6 CR +2 V +2 04/19/16, 19:25
-
Gerrit merged patch set 6 04/19/16, 19:25
GeneralUtility.php:934