Review main Merged

47680[TASK] Add translations to DateTimePicker

Wouter Wolters CR +2 V +2 Normal +86 −6 updated 04/15/16, 13:41

Commit message

The DateTimePicker is only available in english.
Use moment.js with included locales to make the DateTimePicker
translated in the language of the user. If the language is not loaded
it will fallback to english.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Nicole Hummel +1
  • Verified V +2
    • Christian Kuhn +2
    • Nicole Hummel +1

Issues 1

Files 3

Review log 11

  1. Wouter Wolters uploaded patch set 1 04/14/16, 21:54

  2. Nicole Hummel voted on patch set 1 CR +1 04/15/16, 08:34

  3. Gianluigi Martino commented on patch set 1 V -1 04/15/16, 09:44

    tried in master publish date and no translation there..
  4. Wouter Wolters commented on patch set 1 04/15/16, 09:59

    What is your locale? If it can't find your locale it defaults to english
  5. Nicole Hummel commented on patch set 1 V -1 04/15/16, 10:14

    Set locale to "deu_deu" (on Windows system) -> system check reports no error. But no change in labels
  6. Wouter Wolters commented on patch set 1 04/15/16, 10:19

    nicole deu_deu is not valid. the locale means the language which is set in the uc[lang]
  7. Nicole Hummel commented on patch set 1 V +1 04/15/16, 10:32

    Thanks for clarification. Set user setting to German and updated the language files.
  8. Gianluigi Martino voted on patch set 1 V 0 04/15/16, 10:56

  9. Christian Kuhn voted on patch set 1 CR +2 V +2 04/15/16, 13:35

  10. Gerrit merged patch set 1 04/15/16, 13:37

  11. Christian Kuhn commented on patch set 2 04/15/16, 13:41

    wouter will take care of backport.