Review main Merged

47689[BUGFIX] Fix broken composer constraint

Frank Nägler CR +2 V +2 Easy +4 −4 updated 04/15/16, 09:58

Commit message

A composer diagnose shows two broken version contraints. This patch 
fixes it. Maybe this fixes a side effect which randomly removes folders 
from the vendor path.
Anyway, this fix is a good idea!

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Oliver Klee +1
    • Mathias Brodala +1
    • Nicole Hummel +1
    • Susi Moog +1
  • Verified V +2
    • Christian Kuhn +2
    • Nicole Hummel +1
    • Susi Moog +1

Issues 1

Files 2

Review log 15

  1. Frank Nägler uploaded patch set 1 04/15/16, 07:52

  2. Frank Nägler voted on patch set 1 CR -2 04/15/16, 07:52

  3. Mathias Brodala commented on patch set 1 CR -1 04/15/16, 07:55

    The Composer output shows that this kind of constraint "should be avoided", not that it's broken. In this particular case the constraints are fine since indeed allow anything between 2.7 and 3.0
  4. Frank Nägler commented on patch set 1 04/15/16, 08:01

    As described in the issue, before the patch, composer diagnose output: Checking composer.json: FAIL After the patch, all is fine and the constraint works as before. Anyway, a single pipe as version separator is nowhere mentioned in the composer documentation.
  5. Susi Moog commented on patch set 1 CR +1 04/15/16, 08:10

    @Mathias, nope, the current constraint does not make sense, as it allows everything below 3.1 ... and everything above 2.7... so basically it allows nearly everything. you can check at https://semver.mwl.be/#?package=symfony%2Fconsole&version=%3E%3D2.7%20%7C%20%3C3.1&minimum-stability=stable
  6. Wouter Wolters commented on patch set 1 04/15/16, 08:14

    constraint
  7. Susi Moog updated the commit message in patch set 2 04/15/16, 08:19

  8. Susi Moog voted on patch set 2 CR +1 V +1 04/15/16, 08:19

  9. Frank Nägler voted on patch set 2 CR 0 04/15/16, 08:19

  10. Nicole Hummel commented on patch set 2 CR -1 04/15/16, 08:27

    composer.json:32

    "Ranges separated by a space ( ) or comma (,) will be treated as a logical AND. A double pipe (||) will be treated as a logical OR" IMHO we need the double pipe here
  11. Mathias Brodala commented on patch set 2 CR +1 04/15/16, 08:27

    @Susi, damn you're right, this must indeed be a logical AND instead of OR.
  12. Nicole Hummel commented on patch set 2 CR +1 V +1 04/15/16, 08:28

    composer.json:32 Reply

    Wrong, sorry... We need the AND of course...
  13. Oliver Klee voted on patch set 2 CR +1 04/15/16, 09:38

  14. Christian Kuhn voted on patch set 2 CR +2 V +2 04/15/16, 09:58

  15. Gerrit merged patch set 2 04/15/16, 09:58