Review main Abandoned

47708[BUGFIX] Keep link contents in MS browsers after URL change

Jigal van Hemert CR 0 V 0 Easy +12 −3 updated 05/04/17, 18:28

Commit message

In MS browsers the contents of a link need to be restored after the URL
has changed. With correct detection of IE11 and added condition for Edge
this happens now in RTE HTMLarea when modifying the URL of an existing
external link.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 12

  1. Jigal van Hemert uploaded patch set 1 04/15/16, 13:37

  2. Andreas Kienast voted on patch set 1 CR +1 04/15/16, 17:33

  3. Daniel Goerz voted on patch set 1 CR +1 04/17/16, 14:48

  4. Susi Moog commented on patch set 1 CR +1 V +1 04/17/16, 18:14

    tested on Win 10 / Edge.
  5. Wouter Wolters commented on patch set 1 04/18/16, 10:05

    doesn't work on my system with Edge and IE11, Jigal saw this happening here at the sprint.
  6. Wouter Wolters rebased onto patch set 2 04/18/16, 11:38

  7. Nicole Hummel commented on patch set 2 V -1 04/20/16, 10:19

    Not working with IE 11
  8. Jigal van Hemert commented on patch set 2 CR -2 04/21/16, 07:55

    There are two different functionalities here: 1) click inside a link and change the URL; this is now fixed for IE11/Edge 2) select some text (may be the link text); this first removes links from the selection and then applies the (new) URL. This is somehow broken in IE/Edge
  9. Jigal van Hemert uploaded patch set 3 04/23/16, 20:39

  10. Jigal van Hemert commented on patch set 3 V -1 04/23/16, 20:40

    Just added some code and comments for a JS / RTE expert. Will ask Stanislas to have a look
  11. Susi Moog commented on patch set 3 12/08/16, 20:34

    how about abandoning this one or will something happen here? With ckeditor in master?
  12. Wouter Wolters abandoned the change 05/04/17, 18:28

    will not happen for master anymore. If this is still needed please create a PR on github https://github.com/FriendsOfTYPO3/rtehtmlarea