Review main Abandoned

4771[BUGFIX] Hardcoded labels are cleared by language class

Andreas Wolf CR 0 V 0 Easy +4 −0 updated 06/03/13, 20:49

Commit message

The method sL() in typo3/sysext/lang/lang.php returns an empty string
for hardcoded labels. As this is officially supported according to our
documentation (see e.g. the description of TCA type "select" in "TYPO3
Core API"), this is a bug.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 6

  1. Andreas Wolf commented on patch set 1 09/05/11, 16:04

    You're right, this got fixed in the meantime... I was just using an old Core version from Incubator...
  2. Xavier Perseguers commented on patch set 1 09/05/11, 16:04

    (1 inline comment)

    lang.php:385

    It should fallback to $input here... why is your patch needed?
  3. Xavier Perseguers commented on patch set 1 09/05/11, 16:04

    I would prefer that you didn't submit this Your code snippet is wrong in the bug tracker, it should be $GLOBALS['LANG']->sL('something'); with 'LANG' in upper case. I cannot reproduce this when adding a debug statement for this in a backend module.
  4. Xavier Perseguers commented on patch set 1 09/05/11, 16:04

    Fails
  5. Mr. Jenkins commented on patch set 1 09/05/11, 16:04

  6. Andreas Wolf commented on patch set 1 09/05/11, 16:04

    Abandoned Patch is irrelevant, as the issue was fixed in the meantime.