Review main Merged Breaking

47721[!!!][TASK] Always store <p> tags in DB from RTE

Benni Mack CR +2 V +2 Normal +66 −31 updated 04/20/16, 08:55

Commit message

Twelve years ago, when the RTE was not working in
every browser, TYPO3 always stored as little
html code in the database as possible.

Now it's time to really store HTML in the database
so the custom transformations from RTE to DB
(and vice versa) and from DB to the frontend
are getting less.

This introduces less overhead and also makes
it easier to work with the content that
is stored in the database.

An upgrade wizard (coming separately) will ensure
that all existing fields will be migrated.

Review

  • Code review CR +2
    • Benni Mack +2
    • Michiel Roos +1
    • Nicole Hummel +1
  • Verified V +2
    • Benni Mack +2
    • Michiel Roos +1
    • Nicole Hummel +1

Issues 1

Files 3

Review log 21

  1. Benni Mack uploaded patch set 1 04/15/16, 18:57

  2. Benni Mack uploaded patch set 2 04/15/16, 19:18

  3. Benni Mack uploaded patch set 3 04/15/16, 19:33

  4. Benni Mack uploaded patch set 4 04/15/16, 19:43

  5. Benni Mack uploaded patch set 5 04/15/16, 19:46

  6. Oliver Hader voted on patch set 5 CR +1 V +1 04/15/16, 19:47

  7. Benni Mack uploaded patch set 6 04/15/16, 19:47

  8. Frank Nägler voted on patch set 6 CR +1 V +1 04/15/16, 19:53

  9. Mathias Schreiber commented on patch set 6 CR -2 04/16/16, 08:27

    Blocked until Documentation RST has been added
  10. Benni Mack uploaded patch set 7 04/16/16, 10:15

  11. Mathias Schreiber voted on patch set 7 CR 0 04/16/16, 12:10

  12. Andreas Kienast commented on patch set 7 CR +1 04/16/16, 15:21

    RteHtmlParser.php:1027

    Afaik this musn't be an array anymore if $search is an array. But that's more a hint, not a hard requirement :)
  13. Michiel Roos commented on patch set 7 04/18/16, 09:53

    RteHtmlParser.php:1027 Reply

    +1

    RteHtmlParser.php:1028

    Then do so: ? Wrap in p tags? Including attributes?

    RteHtmlParser.php:1029

    Maybe use 'rtrim' here?
  14. Richard Haeser voted on patch set 7 CR +1 04/18/16, 11:47

  15. Benni Mack commented on patch set 8 04/19/16, 08:03

    Published edit on patch set 7.
  16. Nicole Hummel commented on patch set 8 04/19/16, 10:35

    IMHO this patch makes lib.parseFunc_RTE.nonTypoTagStdWrap.encapsLines.nonWrappedTag obsolete?!

    Breaking-75708-AlwaysStorePTagsInDBFromRTE.rst:9

    two different times the <p> tags were removed? not sure this was intended like that.
  17. Benni Mack commented on patch set 9 04/19/16, 15:58

    Published edit on patch set 8.
  18. Nicole Hummel voted on patch set 9 CR +1 V +1 04/19/16, 16:23

  19. Michiel Roos voted on patch set 9 CR +1 V +1 04/20/16, 08:12

  20. Benni Mack voted on patch set 9 CR +2 V +2 04/20/16, 08:55

  21. Gerrit merged patch set 9 04/20/16, 08:55