47721[!!!][TASK] Always store <p> tags in DB from RTE
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Michiel Roos +1
- Nicole Hummel +1
-
Verified V +2
- Benni Mack +2
- Michiel Roos +1
- Nicole Hummel +1
Issues 1
Files 3
Review log 21
-
Benni Mack uploaded patch set 1 04/15/16, 18:57
-
Benni Mack uploaded patch set 2 04/15/16, 19:18
-
Benni Mack uploaded patch set 3 04/15/16, 19:33
-
Benni Mack uploaded patch set 4 04/15/16, 19:43
-
Benni Mack uploaded patch set 5 04/15/16, 19:46
-
Oliver Hader voted on patch set 5 CR +1 V +1 04/15/16, 19:47
-
Benni Mack uploaded patch set 6 04/15/16, 19:47
-
Frank Nägler voted on patch set 6 CR +1 V +1 04/15/16, 19:53
-
Mathias Schreiber commented on patch set 6 CR -2 04/16/16, 08:27
Blocked until Documentation RST has been added -
Benni Mack uploaded patch set 7 04/16/16, 10:15
-
Mathias Schreiber voted on patch set 7 CR 0 04/16/16, 12:10
-
Andreas Kienast commented on patch set 7 CR +1 04/16/16, 15:21
RteHtmlParser.php:1027Afaik this musn't be an array anymore if $search is an array. But that's more a hint, not a hard requirement :) -
Michiel Roos commented on patch set 7 04/18/16, 09:53
RteHtmlParser.php:1027Reply+1RteHtmlParser.php:1028Then do so: ? Wrap in p tags? Including attributes?RteHtmlParser.php:1029Maybe use 'rtrim' here? -
Richard Haeser voted on patch set 7 CR +1 04/18/16, 11:47
-
Benni Mack commented on patch set 8 04/19/16, 08:03
Published edit on patch set 7. -
Nicole Hummel commented on patch set 8 04/19/16, 10:35
IMHO this patch makes lib.parseFunc_RTE.nonTypoTagStdWrap.encapsLines.nonWrappedTag obsolete?!Breaking-75708-AlwaysStorePTagsInDBFromRTE.rst:9two different times the <p> tags were removed? not sure this was intended like that. -
Benni Mack commented on patch set 9 04/19/16, 15:58
Published edit on patch set 8. -
Nicole Hummel voted on patch set 9 CR +1 V +1 04/19/16, 16:23
-
Michiel Roos voted on patch set 9 CR +1 V +1 04/20/16, 08:12
-
Benni Mack voted on patch set 9 CR +2 V +2 04/20/16, 08:55
-
Gerrit merged patch set 9 04/20/16, 08:55