Review main Merged Breaking

47728[!!!][TASK] Drop RTE config skipAlign and skipClass

Benni Mack CR +2 V +2 Normal +48 −25 updated 05/06/16, 08:31

Commit message

The two options to define whether to not allow align or class
attributes on <p> tags when converting from RTE to the DB
are dropped in favor of using keepPDIVattribs and adding them there
by default.

Review

  • Code review CR +2
    • Nicole Hummel +2
    • Daniel Goerz +1
    • Georg Ringer +1
    • Wouter Wolters +1
    • Frank Nägler +1
  • Verified V +2
    • Nicole Hummel +2
    • Georg Ringer +1

Issues 1

Files 3

Review log 15

  1. Benni Mack uploaded patch set 1 04/16/16, 10:36

  2. Benni Mack uploaded patch set 2 04/16/16, 11:16

  3. Andreas Kienast commented on patch set 2 04/17/16, 13:16

    Breaking-75710-RTE-relatedTSconfigOptionsSkipAlignAndSkipClassRemoved.rst:21

    is this correct here?
  4. Benni Mack commented on patch set 3 04/18/16, 04:49

    Published edit on patch set 2.
  5. Benni Mack commented on patch set 3 04/18/16, 04:50

    @andy.f - yes. if you have keepPDIVattribs set to a custom value and do not have "skipClass", then classes will now not be kept on transformations anymore (which it did by default by hidden magic). Any good idea on how to put that in the RST file?
  6. Andreas Kienast commented on patch set 3 04/20/16, 07:46

    Something like this? Any installation setting custom TSconfig options for ``skipAlign``, ``skipClass`` or setting ``keepPDIVattribs`` without ``class`` and ``align`` as values are affected.
  7. Andreas Kienast commented on patch set 4 04/20/16, 07:49

    Published edit on patch set 3.
  8. Wouter Wolters voted on patch set 4 CR +1 04/24/16, 14:15

  9. Georg Ringer voted on patch set 4 CR +1 V +1 04/24/16, 19:39

  10. Frank Nägler voted on patch set 4 CR +1 04/25/16, 08:19

  11. Daniel Goerz voted on patch set 4 CR +1 05/04/16, 20:03

  12. Nicole Hummel voted on patch set 4 CR +1 05/04/16, 21:36

  13. Nicole Hummel commented on patch set 4 CR -1 05/06/16, 08:22

    RteHtmlParser.php:1006

    true missing

    RteHtmlParser.php:1006

    what about the tagAttributes here? Old code used this variable
  14. Nicole Hummel commented on patch set 4 CR +2 V +2 05/06/16, 08:31

    RteHtmlParser.php:1006 Reply

    Ah, as "class" and "align" are in the $allowedAttributesForParagraphTags now, those are already set
  15. Gerrit merged patch set 4 05/06/16, 08:31