47728[!!!][TASK] Drop RTE config skipAlign and skipClass
Commit message
Review
-
Code review CR +2
- Nicole Hummel +2
- Daniel Goerz +1
- Georg Ringer +1
- Wouter Wolters +1
- Frank Nägler +1
-
Verified V +2
- Nicole Hummel +2
- Georg Ringer +1
Issues 1
Files 3
Review log 15
-
Benni Mack uploaded patch set 1 04/16/16, 10:36
-
Benni Mack uploaded patch set 2 04/16/16, 11:16
-
Andreas Kienast commented on patch set 2 04/17/16, 13:16
-
Benni Mack commented on patch set 3 04/18/16, 04:49
Published edit on patch set 2. -
Benni Mack commented on patch set 3 04/18/16, 04:50
@andy.f - yes. if you have keepPDIVattribs set to a custom value and do not have "skipClass", then classes will now not be kept on transformations anymore (which it did by default by hidden magic). Any good idea on how to put that in the RST file? -
Andreas Kienast commented on patch set 3 04/20/16, 07:46
Something like this? Any installation setting custom TSconfig options for ``skipAlign``, ``skipClass`` or setting ``keepPDIVattribs`` without ``class`` and ``align`` as values are affected. -
Andreas Kienast commented on patch set 4 04/20/16, 07:49
Published edit on patch set 3. -
Wouter Wolters voted on patch set 4 CR +1 04/24/16, 14:15
-
Georg Ringer voted on patch set 4 CR +1 V +1 04/24/16, 19:39
-
Frank Nägler voted on patch set 4 CR +1 04/25/16, 08:19
-
Daniel Goerz voted on patch set 4 CR +1 05/04/16, 20:03
-
Nicole Hummel voted on patch set 4 CR +1 05/04/16, 21:36
-
Nicole Hummel commented on patch set 4 CR -1 05/06/16, 08:22
RteHtmlParser.php:1006true missingRteHtmlParser.php:1006what about the tagAttributes here? Old code used this variable -
Nicole Hummel commented on patch set 4 CR +2 V +2 05/06/16, 08:31
RteHtmlParser.php:1006ReplyAh, as "class" and "align" are in the $allowedAttributesForParagraphTags now, those are already set -
Gerrit merged patch set 4 05/06/16, 08:31
Breaking-75710-RTE-relatedTSconfigOptionsSkipAlignAndSkipClassRemoved.rst:21