Review main Merged

47729[TASK] Cleanup variables inside RteHtmlParser

Benni Mack CR +2 V +2 Easy +10 −14 updated 04/19/16, 11:26

Commit message

Various cleanings to understand the code better.

Review

  • Code review CR +2
    • Benni Mack +2
    • Daniel Goerz +1
    • Wouter Wolters +1
    • Nicole Hummel +1
  • Verified V +2
    • Benni Mack +2
    • Wouter Wolters +1
    • Nicole Hummel +1

Issues 1

Files 1

Review log 10

  1. Benni Mack uploaded patch set 1 04/16/16, 10:58

  2. Benni Mack updated the commit message in patch set 2 04/18/16, 09:36

  3. Wouter Wolters commented on patch set 2 CR -1 04/18/16, 10:31

    many failing unit tests after applying this.
  4. Benni Mack uploaded patch set 3 04/19/16, 04:59

  5. Wouter Wolters voted on patch set 3 CR +1 V +1 04/19/16, 08:54

  6. Daniel Goerz voted on patch set 3 CR +1 04/19/16, 10:16

  7. Nicole Hummel commented on patch set 3 CR -1 04/19/16, 10:18

    On it
  8. Nicole Hummel voted on patch set 3 CR +1 V +1 04/19/16, 10:22

  9. Benni Mack voted on patch set 3 CR +2 V +2 04/19/16, 11:26

  10. Gerrit merged patch set 3 04/19/16, 11:26