Review main Merged

47744[TASK] Remove duplicate exception numbers

Christoph Kratz CR +2 V +2 Easy +23 −23 updated 04/19/16, 12:03

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Daniel Goerz +1
    • Christoph Kratz +1
    • Nicole Hummel +1
  • Verified V +2
    • Christian Kuhn +2
    • Daniel Goerz +1
    • Christoph Kratz +1
    • Nicole Hummel +1

Issues 1

Files 16

Review log 20

  1. Christoph Kratz uploaded patch set 1 04/18/16, 11:43

  2. Wouter Wolters rebased onto patch set 2 04/18/16, 11:46

  3. Wouter Wolters commented on patch set 2 CR -1 04/18/16, 12:11

    should be TASK

    TypoScriptFrontendController.php:946

    should not be changed. This needs to be the same as the exception that throws the exception.
  4. Christoph Kratz uploaded patch set 3 04/18/16, 12:17

  5. Wouter Wolters commented on patch set 3 04/18/16, 12:42

    BackendUserController.php:120

    leave the same here

    DatabaseConnection.php:1621

    leave the same here

    BackendFormProtection.php:104

    leave the same

    BitmapIconProvider.php:46

    leave the same

    IconRegistry.php:2771

    leave the same

    FileLockStrategy.php:61

    leave the same

    FileLockStrategy.php:65

    same here

    ArrayUtility.php:146

    leave the same

    Dispatcher.php:117

    leave the same

    Typo3DbQueryParser.php:368

    keep the same

    SelectViewHelper.php:162

    restore this file completely

    TypoScriptFrontendController.php:4635

    leave the same here

    AddImageHandler.php:134

    keep the same
  6. Christoph Kratz uploaded patch set 4 04/18/16, 13:28

  7. Wouter Wolters voted on patch set 4 CR +1 V +1 04/18/16, 13:47

  8. Frank Nägler commented on patch set 4 CR -1 04/18/16, 14:18

    this is a breaking change, if anyone catch this exceptions and handle it by the given exception code. I am fine with change this in master, but the patch need a breaking rst file and must be marked with [!!!]
  9. Christian Kuhn commented on patch set 4 CR +1 04/18/16, 18:23

    Mmmmh, imho extensions should never rely on specific exception codes. If an extension does it, it either indicates sloppy programming in an extension, or a core bug, if the system follows the following strategy: If core throws a "top-level" php builtin exception like \RuntimeException or \LogicException, then a extension should *never* catch that, since it indicates a hard program logic exception that is raised by a coding bug. OTOH, exceptions that *can* occur during normal code flow and thus should be catchable, those should throw a specific exception like \TYPO3\CMS\MyApiExtension\Exception\FoobarWentWrongException. Those could then be caught by an extension using that API. Again, no code needs to be checked for, here. Thus, I'd say we *can* change exception codes. I'd not do that in 7.6 and only in master, but in general, as outlined, if an extension is forced to catch specific exception codes, it would rather indicate a *different* type of issue that should be solved differently anyway.
  10. Frank Nägler commented on patch set 4 CR 0 04/18/16, 18:34

    after a short discussion, I will not block this patch. remove my voting.
  11. Nicole Hummel commented on patch set 4 CR -1 04/19/16, 08:59

    On it
  12. Nicole Hummel uploaded patch set 5 04/19/16, 09:29

  13. Nicole Hummel uploaded patch set 6 04/19/16, 09:38

  14. Nicole Hummel uploaded patch set 7 04/19/16, 09:58

  15. Nicole Hummel commented on patch set 7 CR +1 V +1 04/19/16, 10:01

    Cleaned up the last push
  16. Christoph Kratz commented on patch set 7 CR +1 V +1 04/19/16, 10:03

    Tested with script from #47765. Everything is clean.
  17. Daniel Goerz voted on patch set 7 CR +1 V +1 04/19/16, 10:08

  18. Christian Kuhn commented on patch set 7 04/19/16, 11:56

    on it
  19. Christian Kuhn voted on patch set 7 CR +2 V +2 04/19/16, 12:03

  20. Gerrit merged patch set 7 04/19/16, 12:03