Review main Merged

47758[TASK] Remove unused code from RecordHistory

Stephan Großberndt CR +2 V +2 Easy +0 −25 updated 02/10/18, 22:15

Commit message

Removed all occurrences of reading and passing the parameter sumUp,
since it is always set to -1, last usage of different values was in
TYPO3 3.8.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Richard Haeser +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1

Issues 1

Files 4

Review log 8

  1. Stephan Großberndt uploaded patch set 1 04/18/16, 16:40

  2. Stephan Großberndt uploaded patch set 2 04/18/16, 17:07

  3. Wouter Wolters commented on patch set 2 CR +1 V +1 04/18/16, 17:11

    Checked TER as well, sumUp is only set to -1.
  4. Richard Haeser voted on patch set 2 CR +1 04/18/16, 17:13

  5. Christian Kuhn commented on patch set 2 04/18/16, 17:34

    testing
  6. Christian Kuhn voted on patch set 2 CR +2 V +2 04/18/16, 17:43

  7. Gerrit merged patch set 2 04/18/16, 17:43

  8. Tymoteusz Motylewski commented on patch set 3 02/10/18, 22:15

    post -1. This patch removed functionality of "single click revert". If you go to the page properties form, there are 2 "revert" buttons - the first one was about reverting the last change, and the second one was about showing the history module. Since you have removed the "sumUp" argument handling and in the same time "'revert'" argument handling, both buttons do the same now. I think the correct way to go is to remove sumUp arg, but keep "revert" and the corresponding functionality.