47761[FEATURE] Number of files per page in file list configurable
Commit message
Review
-
Code review CR +2
- Nicole Hummel +2
- Susi Moog +1
-
Verified V +2
- Nicole Hummel +2
- Susi Moog +1
Issues 1
Files 2
Review log 16
-
Stephan Großberndt uploaded patch set 1 04/18/16, 18:59
-
Nicole Hummel commented on patch set 1 04/18/16, 22:51
Feature-72923-ConfigurableFileListSize.rst:8numberFileList.php:199better check if $modTSconfig['properties']['filesPerPage'] is set before and just change the iLimit value if so -
Georg Ringer commented on patch set 1 04/19/16, 07:26
Feature-72923-ConfigurableFileListSize.rst:8tsconfig ;) -
Stephan Großberndt rebased onto patch set 2 04/19/16, 08:13
-
Stephan Großberndt uploaded patch set 3 04/19/16, 08:22
-
Nicole Hummel commented on patch set 4 04/19/16, 08:25
Published edit on patch set 3. -
Susi Moog commented on patch set 4 04/19/16, 08:39
FileList.php:201why do you add the max here? It's the default anyway (for whatever reason ;)). If you want to ensure that a max is always used here, we should probably use PHP_INT_MAX instead of a "random" number. -
Stephan Großberndt commented on patch set 1 04/19/16, 08:52
I used the default value because I need to supply $this->iLimit as a last param and thus had to supply a value. Actually when writing the patch I had PHP_INT_MAX in there first and changed to afterwards. I am fine with PHP_INT_MAX too, does not matter if you try to list 2147483647 or 2000000000 files :-D -
Stephan Großberndt commented on patch set 5 04/19/16, 08:54
Published edit on patch set 4. -
Nicole Hummel commented on patch set 5 04/19/16, 08:58
But now the max is still the default -
Susi Moog commented on patch set 5 CR +1 V +1 04/19/16, 09:02
max = default is fine by me, default is high enough ;) I just did not want to see another magic number introduced. -
Nicole Hummel voted on patch set 5 CR +2 V +2 04/19/16, 09:44
-
Gerrit merged patch set 5 04/19/16, 09:44
-
Stephan Großberndt commented on patch set 6 04/28/16, 16:49
Nobody noticed usage of mod.* in user TSconfig is deprecated: https://docs.typo3.org/typo3cms/TSconfigReference/UserTsconfig/TopLevelObjects/Index.html So we need a followup to put the configuration to @options@ instead. -
Stephan Großberndt commented on patch set 6 04/28/16, 16:56
What about options.fileList.filesPerPage? -
Stephan Großberndt commented on patch set 6 04/29/16, 08:47
Followup in https://review.typo3.org/#/c/47966/
Feature-72923-ConfigurableFileListSize.rst:2