Review main Merged

47765[TASK] Script finding duplicate exception codes for Travis

Christoph Kratz CR +2 V +2 Normal +68 −1 updated 04/19/16, 12:19

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Daniel Goerz +1
    • Stephan Großberndt +1
    • Nicole Hummel +1
    • Helmut Hummel +1
  • Verified V +2
    • Christian Kuhn +2
    • Daniel Goerz +1
    • Stephan Großberndt +1
    • Nicole Hummel +1
    • Helmut Hummel +1

Issues 1

Files 2

Review log 28

Show 3 earlier messages
  1. Christoph Kratz uploaded patch set 1 04/18/16, 21:44

  2. Christoph Kratz voted on patch set 1 CR -1 V -1 04/18/16, 22:07

  3. Christoph Kratz uploaded patch set 2 04/18/16, 22:11

  1. Christian Kuhn commented on patch set 2 04/18/16, 22:27

    testing
  2. Nicole Hummel commented on patch set 2 04/18/16, 22:30

    .travis.yml:8

    simply EXCEPTIONCODE_TEST should be enough and more readable

    duplicateExceptionCodeCheck.sh:50

    Shouldn't the exit code be 1 if possible errors were found?
  3. Christian Kuhn commented on patch set 2 04/18/16, 22:30

    duplicateExceptionCodeCheck.sh:30

    could we limit this to test in typo3/ only? for me it now spits out lots of possible duplicates from extensions ^^
  4. Wouter Wolters commented on patch set 2 04/18/16, 22:34

    we are on it
  5. Christian Kuhn commented on patch set 2 04/18/16, 22:37

    duplicateExceptionCodeCheck.sh:50 Reply

    yep, i'd prefer that, too: as soon as core is clean / script is finished this test should render travis red if a duplicate exception code is detected.
  6. Christoph Kratz uploaded patch set 3 04/18/16, 22:42

  7. Nicole Hummel commented on patch set 3 04/18/16, 22:56

    duplicateExceptionCodeCheck.sh:47

    Now you are exiting after the first error.
  8. Markus Klein commented on patch set 3 04/19/16, 07:04

    Just a note: Maybe take the existing script for XLF ID checks as an inspiration too.
  9. Wouter Wolters uploaded patch set 4 04/19/16, 07:58

  10. Wouter Wolters voted on patch set 4 CR +1 V +1 04/19/16, 07:59

  11. Mathias Brodala commented on patch set 5 04/19/16, 08:01

    Published edit on patch set 4.
  12. Mathias Brodala commented on patch set 5 04/19/16, 08:01

    Allowed to set ACK via environment variable
  13. Wouter Wolters voted on patch set 5 CR +1 V +1 04/19/16, 08:14

  14. Nicole Hummel voted on patch set 5 CR +1 04/19/16, 08:55

  15. Stephan Großberndt commented on patch set 5 CR -1 04/19/16, 09:09

    on it
  16. Stephan Großberndt uploaded patch set 6 04/19/16, 09:19

  17. Stephan Großberndt voted on patch set 6 CR +1 V +1 04/19/16, 09:27

  18. Nicole Hummel voted on patch set 6 CR +1 04/19/16, 10:05

  19. Nicole Hummel commented on patch set 6 V +1 04/19/16, 10:06

    Saw it running on Christoph's notebook
  20. Daniel Goerz voted on patch set 6 CR +1 V +1 04/19/16, 10:12

  21. Christian Kuhn commented on patch set 6 04/19/16, 12:04

    will run through catharsis once ... will merge if ok there.
  22. Helmut Hummel voted on patch set 6 CR +1 V +1 04/19/16, 12:13

  23. Helmut Hummel commented on patch set 6 04/19/16, 12:19

  24. Christian Kuhn voted on patch set 6 CR +2 V +2 04/19/16, 12:19

  25. Gerrit merged patch set 6 04/19/16, 12:19