47765[TASK] Script finding duplicate exception codes for Travis
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Daniel Goerz +1
- Stephan Großberndt +1
- Nicole Hummel +1
- Helmut Hummel +1
-
Verified V +2
- Christian Kuhn +2
- Daniel Goerz +1
- Stephan Großberndt +1
- Nicole Hummel +1
- Helmut Hummel +1
Issues 1
Files 2
Review log 28
Show 3 earlier messages
-
Christian Kuhn commented on patch set 2 04/18/16, 22:27
testing -
Nicole Hummel commented on patch set 2 04/18/16, 22:30
.travis.yml:8simply EXCEPTIONCODE_TEST should be enough and more readableduplicateExceptionCodeCheck.sh:50Shouldn't the exit code be 1 if possible errors were found? -
Christian Kuhn commented on patch set 2 04/18/16, 22:30
duplicateExceptionCodeCheck.sh:30could we limit this to test in typo3/ only? for me it now spits out lots of possible duplicates from extensions ^^ -
Wouter Wolters commented on patch set 2 04/18/16, 22:34
we are on it -
Christian Kuhn commented on patch set 2 04/18/16, 22:37
duplicateExceptionCodeCheck.sh:50Replyyep, i'd prefer that, too: as soon as core is clean / script is finished this test should render travis red if a duplicate exception code is detected. -
Christoph Kratz uploaded patch set 3 04/18/16, 22:42
-
Nicole Hummel commented on patch set 3 04/18/16, 22:56
duplicateExceptionCodeCheck.sh:47Now you are exiting after the first error. -
Markus Klein commented on patch set 3 04/19/16, 07:04
Just a note: Maybe take the existing script for XLF ID checks as an inspiration too. -
Wouter Wolters uploaded patch set 4 04/19/16, 07:58
-
Wouter Wolters voted on patch set 4 CR +1 V +1 04/19/16, 07:59
-
Mathias Brodala commented on patch set 5 04/19/16, 08:01
Published edit on patch set 4. -
Mathias Brodala commented on patch set 5 04/19/16, 08:01
Allowed to set ACK via environment variable -
Wouter Wolters voted on patch set 5 CR +1 V +1 04/19/16, 08:14
-
Nicole Hummel voted on patch set 5 CR +1 04/19/16, 08:55
-
Stephan Großberndt commented on patch set 5 CR -1 04/19/16, 09:09
on it -
Stephan Großberndt uploaded patch set 6 04/19/16, 09:19
-
Stephan Großberndt voted on patch set 6 CR +1 V +1 04/19/16, 09:27
-
Nicole Hummel voted on patch set 6 CR +1 04/19/16, 10:05
-
Nicole Hummel commented on patch set 6 V +1 04/19/16, 10:06
Saw it running on Christoph's notebook -
Daniel Goerz voted on patch set 6 CR +1 V +1 04/19/16, 10:12
-
Christian Kuhn commented on patch set 6 04/19/16, 12:04
will run through catharsis once ... will merge if ok there. -
Helmut Hummel voted on patch set 6 CR +1 V +1 04/19/16, 12:13
-
Helmut Hummel commented on patch set 6 04/19/16, 12:19
worked for me yesterday: https://travis-ci.org/helhum/TYPO3.CMS/builds/124047954 -
Christian Kuhn voted on patch set 6 CR +2 V +2 04/19/16, 12:19
-
Gerrit merged patch set 6 04/19/16, 12:19