Review main Merged

47771[TASK] Remove last part of singleton pattern in getUserObj()

Benni Mack CR +2 V +2 Normal +23 −32 updated 04/19/16, 08:49

Commit message

In 8.0, the logic for having getUserObj() called with a "&" to
implement a singleton pattern has been removed, however
some code is still left and now unused.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Nicole Hummel +1
  • Verified V +2
    • Wouter Wolters +2
    • Nicole Hummel +1

Issues 1

Files 5

Review log 11

  1. Benni Mack uploaded patch set 1 04/19/16, 06:03

  2. Wouter Wolters commented on patch set 1 CR -1 04/19/16, 08:24

    fails, on it.
  3. Wouter Wolters uploaded patch set 2 04/19/16, 08:39

  4. Wouter Wolters voted on patch set 2 CR +1 V +1 04/19/16, 08:40

  5. Nicole Hummel commented on patch set 3 04/19/16, 08:42

    Published edit on patch set 2.
  6. Wouter Wolters voted on patch set 3 CR +1 V +1 04/19/16, 08:42

  7. Nicole Hummel commented on patch set 3 CR -1 04/19/16, 08:44

    On it

    GeneralUtility.php:3768

    The example should be adjusted
  8. Nicole Hummel uploaded patch set 4 04/19/16, 08:47

  9. Nicole Hummel voted on patch set 4 CR +1 V +1 04/19/16, 08:47

  10. Wouter Wolters voted on patch set 4 CR +2 V +2 04/19/16, 08:49

  11. Gerrit merged patch set 4 04/19/16, 08:49