Review main Merged

47789[TASK] Only show filemount path selection when storage is selected

Frans Saris CR +2 V +2 Easy +11 −1 updated 04/20/16, 19:49

Commit message

Review

  • Code review CR +2
    • Philipp Gampe +2
    • Susi Moog +1
  • Verified V +2
    • Philipp Gampe +2
    • Susi Moog +1

Issues 1

Files 1

Review log 14

  1. Frans Saris uploaded patch set 1 04/19/16, 14:41

  2. Wouter Wolters voted on patch set 1 CR +1 04/19/16, 21:12

  3. Philipp Gampe voted on patch set 1 CR +1 V +1 04/19/16, 22:03

  4. Susi Moog commented on patch set 1 V -1 04/20/16, 11:34

    see comment. As a side note: even if the required label is missing requestUpdate saves the record - so my required field isn't required in any case (but at a guess I'd say that is form engine in general)

    sys_filemounts.php:59

    that creates an 'invalid value' for me if I switch between a selected filemount and the empty option. I'd guess 0 would work?
  5. Frans Saris uploaded patch set 2 04/20/16, 12:23

  6. Philipp Gampe commented on patch set 2 CR +1 V +1 04/20/16, 12:39

    better
  7. Susi Moog commented on patch set 2 V -1 04/20/16, 14:12

    2: SQL error: 'Incorrect integer value: '' for column 'base' at row 1' (sys_filemounts:2)
  8. Philipp Gampe commented on patch set 2 04/20/16, 15:35

    @Susi: works for me ... how can I reproduce your issue?
  9. Frans Saris commented on patch set 2 04/20/16, 15:50

    add 'initCommands' => 'SET SESSION sql_mode = \'STRICT_TRANS_TABLES,ERROR_FOR_DIVISION_BY_ZERO,ONLY_FULL_GROUP_BY\';', to [DB][Connections][Default]
  10. Susi Moog uploaded patch set 3 04/20/16, 16:32

  11. Susi Moog commented on patch set 3 CR +1 V +1 04/20/16, 16:37

    traced the problem to DataHandler -> RelationHandler -> readList which basically throws away the zero if it does not find a record with that ID and just returns an empty string. The added tca options allows to set reference to non-existing IDs which is why my addition works without errors. However, that is only a workaround. A real solution would take longer, as figuring out what the default should be is not really possible from TCA only (as the field could also contain comma-separated values - even including table names - and string would then be correct).
  12. Philipp Gampe voted on patch set 3 CR +1 V +1 04/20/16, 19:49

  13. Philipp Gampe voted on patch set 3 CR +2 V +2 04/20/16, 19:49

  14. Gerrit merged patch set 3 04/20/16, 19:49