Review main Merged

47796[BUGFIX] Correct SQL query for BE user filemounts

Benni Mack CR +2 V +2 Easy +2 −3 updated 04/19/16, 20:56

Commit message

Due to a wrong SQL statement, it is not possible
to evaluate any filemounts anymore for be users / groups.

The patch sets a correct SQL statement.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Morton Jonuschat +1
  • Verified V +2
    • Christian Kuhn +2
    • Morton Jonuschat +1

Issues 1

Files 1

Review log 7

  1. Benni Mack uploaded patch set 1 04/19/16, 16:38

  2. Morton Jonuschat voted on patch set 1 CR +1 V +1 04/19/16, 16:40

  3. Christian Kuhn commented on patch set 1 04/19/16, 20:22

    BackendUserAuthentication.php:1587

    deleted = 0 constraint is done by context object automatically.

    BackendUserAuthentication.php:1588

    but why is hidden=0 removed, this is usually not added by backend context query?
  4. Morton Jonuschat commented on patch set 2 04/19/16, 20:28

    Published edit on patch set 1.
  5. Morton Jonuschat voted on patch set 2 CR +1 V +1 04/19/16, 20:28

  6. Christian Kuhn voted on patch set 2 CR +2 V +2 04/19/16, 20:55

  7. Gerrit merged patch set 2 04/19/16, 20:56