Review main Merged

47812[BUGFIX] Remember not rendered checkboxes in TCA treeSelect

Frans Saris CR +2 V +2 Easy +20 −3 updated 04/25/16, 13:00

Commit message

When you have a select field of rendertype selectTree it looses the
selected values of the not rendered checkboxes.

This changes makes sure that also the not rendered values are kept.

Review

  • Code review CR +2
    • Frans Saris +2
    • Frank Nägler +1
    • Jigal van Hemert +1
    • Susi Moog +1
  • Verified V +2
    • Frans Saris +2
    • Frank Nägler +1
    • Jigal van Hemert +1
    • Susi Moog +1
    • Philipp Gampe +1

Issues 1

Files 1

Review log 13

  1. Frans Saris uploaded patch set 1 04/20/16, 13:45

  2. Frans Saris commented on patch set 1 04/20/16, 13:49

    How to test: 1) create a category tree with at least 2 levels 2) check the all categories for a content element 3) collapse all leafs of the category tree 4) save the item 5) now un-check one of the categories but do not open the "sub-categories" 6) save item again and check if the sub-categories are still checked
  3. Peter Foerger voted on patch set 1 CR +1 V +1 04/20/16, 13:54

  4. Philipp Gampe commented on patch set 1 V -1 04/20/16, 14:51

    Frans is working on it
  5. Frans Saris uploaded patch set 2 04/20/16, 15:47

  6. Philipp Gampe commented on patch set 2 V +1 04/20/16, 19:44

    Sorry, I am out on the JS part :/
  7. Jigal van Hemert voted on patch set 2 CR +1 V +1 04/23/16, 19:06

  8. Susi Moog voted on patch set 2 CR +1 V +1 04/24/16, 13:46

  9. Frank Nägler voted on patch set 2 CR +1 04/25/16, 09:06

  10. Frank Nägler voted on patch set 2 V +1 04/25/16, 12:50

  11. Frans Saris voted on patch set 2 CR +2 V +2 04/25/16, 13:00

  12. Gerrit merged patch set 2 04/25/16, 13:00

  13. Frans Saris commented on patch set 3 04/25/16, 13:00

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit f437f2524ae5fd37e2a01b128b177eebe22e1d3d