47813[BUGFIX] Set semantic value to autocomplete
Commit message
Review
-
Code review CR +2
- Susi Moog +2
- Markus Sommer +1
-
Verified V +2
- Susi Moog +2
- Markus Sommer +1
Issues 1
Files 3
Review log 16
-
Nicole Hummel uploaded patch set 1 04/20/16, 14:05
-
Nicole Hummel uploaded patch set 2 04/21/16, 13:29
-
Nicole Hummel updated the commit message in patch set 3 04/21/16, 13:35
-
Frank Nägler commented on patch set 3 04/21/16, 14:13
InputColorPickerElement.php:117autocomplete can/should only contains "on" or "off". See: http://www.w3schools.com/tags/att_input_autocomplete.asp I read the issue and also the bug report for chrome, but I am not sure about this solution for the following reasons: 1) because of browser bug, we should not make our markup invalid. 2) imho autocomplete is not responsible for auto-fill in the browsers. Chrome miss-use this attribute. I will not down-vote this patch, but if possible think of any other solution. maybe remove the pre-filled values with JavaScript if it is possible. -
Nicole Hummel uploaded patch set 4 04/21/16, 14:32
-
Susi Moog commented on patch set 4 V -1 04/22/16, 06:10
Still fails for me. I did some digging and I guess it's because my password field is not a input field, but rsaInput, therefor being rendered by class RsaInputElement. -
Nicole Hummel uploaded patch set 5 04/22/16, 09:50
-
Nicole Hummel commented on patch set 5 04/22/16, 09:50
@Susi: Thanks. I tested with another extension and forgot to change the RsaInputElement -
Susi Moog commented on patch set 5 CR +1 V +1 04/24/16, 09:01
For more information: https://bugs.chromium.org/p/chromium/issues/detail?id=468153 (last comment) so in case anybody still wonders, this solution is the one recommended by chrome. -
Frank Nägler commented on patch set 5 04/25/16, 08:34
InputColorPickerElement.php:118Why the InputColorPickerElement has this attribute/config? Imho the element don't need it. It was introduced some days ago, lets remove this config/attribute now, no reason for keep this for this special field type. -
Wouter Wolters commented on patch set 5 04/25/16, 08:40
I agree with Frank here, that is a C&P ;) -
Nicole Hummel commented on patch set 5 04/25/16, 08:56
InputColorPickerElement.php:118ReplyThe patch https://review.typo3.org/43883/ introduced autocomplete off to all input fields. As it doesn't harm anything I opt to keep that here -
Frank Nägler commented on patch set 5 04/25/16, 10:19
InputColorPickerElement.php:118ReplyI am fine, let it as it is, we will cleanup the class later. there is more useless code in the ColorPicker class. -
Markus Sommer commented on patch set 5 CR +1 V +1 04/29/16, 10:50
Works fine :) -
Susi Moog voted on patch set 5 CR +2 V +2 04/29/16, 17:47
-
Gerrit merged patch set 5 04/29/16, 17:47
InputColorPickerElement.php:117