Review main Abandoned

47825[BUGFIX] Respect locale settings in FloatConverter

Nicole Hummel CR 0 V 0 Easy +18 −0 updated 04/20/16, 21:47

Commit message

This patch adds a conversion for strings to be able to handle different
locales.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 5

  1. Nicole Hummel uploaded patch set 1 04/20/16, 17:40

  2. Morton Jonuschat commented on patch set 2 04/20/16, 19:11

    Published edit on patch set 1.
  3. Morton Jonuschat commented on patch set 2 V -1 04/20/16, 19:13

    Test fails on Mac OS X, PHP7. Selected Locale is de_DE. Reason seems to be that according to localeconv no thousands_sep is defined.
  4. Nicole Hummel commented on patch set 2 04/20/16, 20:00

    \o/ have written a test which works on Windows but not on osx
  5. Nicole Hummel abandoned the change 04/20/16, 21:47

    This is abandoned as it is the wrong way in fixing the issue. The issue is solved with https://review.typo3.org/47828/ The new feature for the FloatConverter is added with https://review.typo3.org/47829/