Review main Merged

47828Revert "[BUGFIX] config.locale_all should format floating point values"

Nicole Hummel CR +2 V +2 Easy +9 −2 updated 04/21/16, 15:21

Commit message

PHP 7 still has the problem converting a float to a string is
locale-aware (https://bugs.php.net/bug.php?id=53711). This means a float
might be returned with a comma as decimal point. This is not intended
and breaks value conversions so this patch restores the old behavior.

This reverts commit 7cbef93a8698347bc55e364fb7ffa3e796b733ec.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Benni Mack +2
    • Oliver Klee +1
    • Stephan Großberndt +1
    • Susi Moog +1
  • Verified V +2
    • Helmut Hummel +2
    • Benni Mack +2
    • Stephan Großberndt +1

Issues 2

Files 1

Review log 10

  1. Nicole Hummel uploaded patch set 1 04/20/16, 20:59

  2. Nicole Hummel uploaded patch set 2 04/20/16, 21:07

  3. Stephan Großberndt voted on patch set 2 CR +1 04/20/16, 21:39

  4. Stephan Großberndt uploaded patch set 3 04/20/16, 22:16

  5. Stephan Großberndt voted on patch set 3 CR +1 V +1 04/20/16, 22:17

  6. Benni Mack voted on patch set 3 CR +2 V +2 04/21/16, 07:24

  7. Susi Moog voted on patch set 3 CR +1 04/21/16, 07:39

  8. Oliver Klee voted on patch set 3 CR +1 04/21/16, 08:36

  9. Helmut Hummel voted on patch set 3 CR +2 V +2 04/21/16, 15:21

  10. Gerrit merged patch set 3 04/21/16, 15:21