Review main Merged

47829[FEATURE] Add configuration options to FloatConverter

Nicole Hummel CR +2 V +2 Normal +65 −1 updated 04/21/16, 12:20

Commit message

Converting a string to a float value needs some specific format of the
string (no thousand separator and '.' as decimal point).

So it should be possible to define some pre-sanitation for the
FloatConverter to be able to convert strings like 123,42 to float.

This patch introduces configuration options and sanitizes the string
before parsing it to float.

Review

  • Code review CR +2
    • Philipp Gampe +2
    • Stephan Großberndt +1
  • Verified V +2
    • Philipp Gampe +2
    • Stephan Großberndt +1

Issues 1

Files 3

Review log 7

  1. Nicole Hummel uploaded patch set 1 04/20/16, 21:43

  2. Stephan Großberndt uploaded patch set 2 04/20/16, 22:26

  3. Stephan Großberndt voted on patch set 2 CR +1 04/20/16, 22:27

  4. Philipp Gampe voted on patch set 2 CR +1 V +1 04/20/16, 22:39

  5. Stephan Großberndt voted on patch set 2 V +1 04/20/16, 22:47

  6. Philipp Gampe voted on patch set 2 CR +2 V +2 04/21/16, 12:20

  7. Gerrit merged patch set 2 04/21/16, 12:20