47837[TASK] Suggest using phpdotenv
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 3
Review log 13
-
Benni Mack uploaded patch set 1 04/21/16, 13:14
-
Benni Mack commented on patch set 1 CR -1 04/21/16, 13:15
Feature RST missing -
Benni Mack uploaded patch set 2 04/21/16, 14:54
-
Philipp Gampe commented on patch set 2 04/21/16, 15:08
composer.json:54why do we needs this? -
Helmut Hummel commented on patch set 2 04/21/16, 15:12
composer.json:54Replybecause it applies magic -
Helmut Hummel commented on patch set 2 04/21/16, 15:12
the connector is now available as 1.0.0 stable -
Helmut Hummel uploaded patch set 3 04/21/16, 15:34
-
Benni Mack commented on patch set 3 CR -1 04/21/16, 15:43
will write RST and a better explanation for this feature (as it is for composer-mode only right now) -
Armin Vieweg commented on patch set 3 04/27/16, 10:49
Very cool! Fortunately you can use the dotenv-connector package of helhum standalone, to set the TYPO3_CONTEXT. -
Christian Kuhn commented on patch set 3 CR -2 04/28/16, 10:02
benni and me had a longer talk about core bootstrap, context and dotenv. we think at the current point in time, this feature is useful, but the final solution will be a bit different and we don't want to make people who would start using dotenv now angry by changing the surrounding code later. i'd opt for postponing this issue for a while, also i'll try to have a chat with helmut next week. to state the wip-nature of this patch, i'll block it with a -2 for now. -
Helmut Hummel uploaded patch set 4 04/28/16, 10:54
-
Helmut Hummel commented on patch set 4 04/28/16, 10:56
Updated the change to have minimal impact. Imho we do not need to force people to use .env By making it a composer suggestion, we also make clear that this can only be used in composer mode. Accepting the root path from the environment is a logical step, that could also go into a separate change, but makes sense to combine it here. Anyway, looking forward to your ideas regarding the bootstrap … -
Benni Mack abandoned the change 07/20/16, 07:42
I think dotenv-connector is the way better approach than adding anything here for now