Review TYPO3_7-6 Merged

47841Revert "[BUGFIX] config.locale_all should format floating point values"

Nicole Hummel CR +2 V +2 Easy +7 −1 updated 04/24/16, 14:01

Commit message

PHP 7 still has the problem converting a float to a string is
locale-aware (https://bugs.php.net/bug.php?id=53711). This means a float
might be returned with a comma as decimal point. This is not intended
and breaks value conversions so this patch restores the old behavior.

This reverts commit 7cbef93a8698347bc55e364fb7ffa3e796b733ec.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Oliver Klee +1
    • Morton Jonuschat +1
  • Verified V +2
    • Wouter Wolters +2
    • Morton Jonuschat +1

Issues 2

Files 1

Review log 7

  1. Nicole Hummel uploaded patch set 1 04/21/16, 15:27

  2. Oliver Klee voted on patch set 1 CR +1 04/21/16, 15:45

  3. Morton Jonuschat voted on patch set 1 CR +1 V +1 04/22/16, 10:21

  4. Frank Nägler commented on patch set 1 CR -1 04/22/16, 11:14

    commit messages misses Reverts-Line, please see the documentation for reverting a patch: https://wiki.typo3.org/Contribution_Walkthrough_with_CommandLine#Reverting_patches
  5. Frank Nägler voted on patch set 1 CR 0 04/22/16, 11:28

  6. Wouter Wolters voted on patch set 1 CR +2 V +2 04/24/16, 14:01

  7. Gerrit merged patch set 1 04/24/16, 14:01