Review main Abandoned

47850[POC][TASK] Remove all TYPO3_MODE dependencies in ext_localconf

Benni Mack CR 0 V 0 Hard +191 −221 updated 08/10/16, 18:30

Commit message

Changing this logic allows to do caching of the global arrays

Review

  • Code review CR 0
  • Verified V 0

Files 16

Review log 78

  1. Benni Mack uploaded patch set 1 04/22/16, 11:36

  2. Benni Mack uploaded patch set 2 05/22/16, 12:37

  3. Oliver Klee commented on patch set 2 05/22/16, 17:27

    ext_localconf.php:58

    Is removing the TYPO3_OS dependency intentional?
  4. Elmar Hinz commented on patch set 2 05/22/16, 18:17

    ext_localconf.php:39

    What are the implications, when releasing this into the FE, if the goal is to cache the giant arrays?
  5. Benni Mack commented on patch set 2 07/11/16, 16:24

    ext_localconf.php:39 Reply

    Well, Signal Slot dispatcher needs to be cached as well then, obviously.
  6. Benni Mack uploaded patch set 3 07/28/16, 14:44

  7. TYPO3com voted on patch set 3 V -1 07/28/16, 14:49 Completed build in 05m 28s on Thu, 28 Jul, 04:49 PM Test Summary: 116 of 19378 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1447

  8. Benni Mack abandoned the change 08/10/16, 18:30

    no further work on that area right now.