Review main Merged

47897[BUGFIX] Handle colspan and rowspan in backend layout wizard

Frank Nägler CR +2 V +2 Normal +49 −31 updated 04/29/16, 18:26

Commit message

This patch fix the handling of colspan and rowspan in backend layout wizard.

Review

  • Code review CR +2
    • Susi Moog +2
    • Markus Sommer +1
  • Verified V +2
    • Susi Moog +2
    • Markus Sommer +1

Issues 1

Files 4

Review log 16

  1. Frank Nägler uploaded patch set 1 04/25/16, 11:59

  2. Andreas Kienast commented on patch set 1 V +1 04/25/16, 12:18

    GridEditor.js:327

    Do we need to check whether rowSpanHelper[col] is undefined?
  3. Frank Nägler commented on patch set 1 04/25/16, 13:34

    GridEditor.js:327 Reply

    no problem because object access this way, does not throw any error if the property is not defined.
  4. Andreas Kienast commented on patch set 1 CR +1 04/25/16, 14:31

    Fine with me
  5. Nicole Hummel voted on patch set 1 CR +1 04/25/16, 14:36

  6. Susi Moog commented on patch set 1 V -1 04/25/16, 16:30

  7. Frank Nägler uploaded patch set 2 04/28/16, 08:56

  8. Nicole Hummel voted on patch set 2 CR +1 04/28/16, 09:45

  9. Wouter Wolters commented on patch set 2 CR -1 04/28/16, 21:06

    this does not work correctly, Frank knows the problem and will work on it tomorrow.
  10. Frank Nägler uploaded patch set 3 04/29/16, 07:50

  11. Frank Nägler commented on patch set 3 CR -1 04/29/16, 07:52

    on it
  12. Frank Nägler uploaded patch set 4 04/29/16, 09:26

  13. Frank Nägler uploaded patch set 5 04/29/16, 09:28

  14. Markus Sommer commented on patch set 5 CR +1 V +1 04/29/16, 11:01

    It works 100x100 cols with rowspan und colspan mix :)
  15. Susi Moog voted on patch set 5 CR +2 V +2 04/29/16, 18:26

  16. Gerrit merged patch set 5 04/29/16, 18:26