47897[BUGFIX] Handle colspan and rowspan in backend layout wizard
Commit message
Review
-
Code review CR +2
- Susi Moog +2
- Markus Sommer +1
-
Verified V +2
- Susi Moog +2
- Markus Sommer +1
Issues 1
Files 4
Review log 16
-
Frank Nägler uploaded patch set 1 04/25/16, 11:59
-
Andreas Kienast commented on patch set 1 V +1 04/25/16, 12:18
-
Frank Nägler commented on patch set 1 04/25/16, 13:34
GridEditor.js:327Replyno problem because object access this way, does not throw any error if the property is not defined. -
Andreas Kienast commented on patch set 1 CR +1 04/25/16, 14:31
Fine with me -
Nicole Hummel voted on patch set 1 CR +1 04/25/16, 14:36
-
Susi Moog commented on patch set 1 V -1 04/25/16, 16:30
https://drive.google.com/file/d/0B5sWHr_PrGE8UGVEUTU4T0FqQk0/view?usp=drivesdk I've still got one problem left. -
Frank Nägler uploaded patch set 2 04/28/16, 08:56
-
Nicole Hummel voted on patch set 2 CR +1 04/28/16, 09:45
-
Wouter Wolters commented on patch set 2 CR -1 04/28/16, 21:06
this does not work correctly, Frank knows the problem and will work on it tomorrow. -
Frank Nägler uploaded patch set 3 04/29/16, 07:50
-
Frank Nägler commented on patch set 3 CR -1 04/29/16, 07:52
on it -
Frank Nägler uploaded patch set 4 04/29/16, 09:26
-
Frank Nägler uploaded patch set 5 04/29/16, 09:28
-
Markus Sommer commented on patch set 5 CR +1 V +1 04/29/16, 11:01
It works 100x100 cols with rowspan und colspan mix :) -
Susi Moog voted on patch set 5 CR +2 V +2 04/29/16, 18:26
-
Gerrit merged patch set 5 04/29/16, 18:26
GridEditor.js:327