Review TYPO3_6-2 Merged

47937[BUGFIX] Allow maxitem=1 in TCA treeSelect again

Alexander Bigga CR +2 V +2 Easy +1 −1 updated 05/01/16, 08:17

Commit message

Introduced with ec7b229 #75519, it was not possible to set maxitem=1 to
TCA treeSelect. This occures e.g. on setting the parent of a
sys_category.

The reason is the "selected" array which gets initialized with all
selected items. If there is no item selected, it is initialized with an
empty value and "selected.lenght" is 1 but should be 0. Selecting a new
value is impossible now.

The proposed path checks if items are selected or not on
initialization.

Review

  • Code review CR +2
    • Frans Saris +2
  • Verified V +2
    • Frans Saris +2

Issues 1

Files 1

Review log 6

  1. Alexander Bigga uploaded patch set 1 04/27/16, 14:02

  2. Wouter Wolters commented on patch set 1 04/27/16, 14:27

    this should be fixed first in master and afterwards backported to 7.6 and 6.2
  3. Alexander Bigga commented on patch set 1 04/27/16, 14:46

    You're totally right. I'll try to push it to master now.
  4. Frans Saris commented on patch set 1 04/29/16, 12:14

    master is merged
  5. Frans Saris voted on patch set 1 CR +2 V +2 04/29/16, 12:15

  6. Gerrit merged patch set 1 05/01/16, 08:17