Review main Merged

47940[BUGFIX] Allow maxitem=1 in TCA treeSelect again

Alexander Bigga CR +2 V +2 Easy +1 −1 updated 04/29/16, 12:14

Commit message

Introduced with ec7b229 #75519, it was not possible to set maxitem=1 to
TCA treeSelect. This occures e.g. on setting the parent of a
sys_category.

The reason is the "selected" array which gets initialized with all
selected items. If there is no item selected, it is initialized with an
empty value and "selected.lenght" is 1 but should be 0. Selecting a new
value is impossible now.

The proposed path checks if items are selected or not on
initialization.

Review

  • Code review CR +2
    • Frans Saris +2
    • Markus Sommer +1
    • Frank Nägler +1
  • Verified V +2
    • Frans Saris +2
    • Markus Sommer +1
    • Philipp Wrann +1

Issues 1

Files 1

Review log 9

  1. Alexander Bigga uploaded patch set 1 04/27/16, 14:52

  2. Frans Saris voted on patch set 1 CR +1 04/27/16, 15:34

  3. Frans Saris voted on patch set 1 V +1 04/28/16, 09:54

  4. Markus Sommer voted on patch set 1 CR +1 V +1 04/29/16, 11:37

  5. Philipp Wrann voted on patch set 1 V +1 04/29/16, 12:02

  6. Frank Nägler voted on patch set 1 CR +1 04/29/16, 12:12

  7. Frans Saris voted on patch set 1 CR +2 V +2 04/29/16, 12:13

  8. Gerrit merged patch set 1 04/29/16, 12:13

  9. Frans Saris commented on patch set 2 04/29/16, 12:14

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 7d36f3ceb9c33be90940e1439a946c7ae89613b9